remove TxString::toCharsArray(char* dest)

VERIFIED WONTFIX

Status

()

Core
XSLT
P3
normal
VERIFIED WONTFIX
18 years ago
16 years ago

People

(Reporter: Axel Hecht, Assigned: Keith Visco)

Tracking

Trunk
Sun
Solaris
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Reporter)

Description

18 years ago
Hi,
this function is not used, well it is called, but just in instances that could
use the toCharsArray() function as well.
This just calls for segfaults.
If nobody is faster, I'll submit a patch.
Peter, you did the string wrappers, right? why are the comments just talking
something different than the code?
Should we attempt a carpool or something to remove these wrappers completely?
They are givin me hell each time I debug.

Axel
(Assignee)

Comment 1

18 years ago
Alex,

WHY????? Is this causing you a problem. I say just leave it as is.

Keith

Comment 2

18 years ago
Axel, first, i didn't write that code, Tom Kneeland did. CVS log should have 
told you that. Keep in mind that at the time he wrote that code, Mozilla's 
string classes were probably quite different from what they are now. Second, 
getting rid of the wrappers is not gonna happen, unless you want standalone to 
disappear, and Keith to learn all of the relevant Mozilla classes.
Anyway, i'm attaching a diff, could you try it out for me? It compiles but i 
haven't really tested it yet.

Comment 3

18 years ago
Created attachment 12147 [details] [diff] [review]
Patch to MozillaString.cpp

Comment 4

18 years ago
Peter that patch does the trick with the strings. But just uncovers a further
fault with stream opening of import/include files. Im working on the stream
problem, Ive opened a new bug to investigate changing the istream handling 47720 .
Just on the string wrapper, im concerned that we are leaking strings, nothing
absolute just a feeling while wandering throu the code, but at this point we
have mutch greater problems to deal with.
Also, why do we use non-Unicode strings so much anyway?
(Assignee)

Comment 5

18 years ago
I need to get this off my list and I haven't seen a good argument as to why we 
need to remove the method.

Status: NEW → RESOLVED
Last Resolved: 18 years ago
Resolution: --- → WONTFIX
(Reporter)

Comment 6

16 years ago
bitching buttons, verfication spam
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.