Closed
Bug 468617
Opened 17 years ago
Closed 17 years ago
OS sniffing doesn't detect OS X 10.5
Categories
(Bugzilla :: Creating/Changing Bugs, defect)
Bugzilla
Creating/Changing Bugs
Tracking
()
RESOLVED
FIXED
Bugzilla 3.2
People
(Reporter: selsky, Assigned: selsky)
References
Details
Attachments
(1 file, 1 obsolete file)
|
751 bytes,
patch
|
timeless
:
review+
|
Details | Diff | Splinter Review |
User-Agent: Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.5; en-US; rv:1.9.0.4) Gecko/2008102920 Firefox/3.0.4
Build Identifier:
Mac OS X 10.5 is detected as 10.4 when the User-Agent string shows 10.5.
User-Agent string:
Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.5; en-US; rv:1.9.0.4) Gecko/2008102920 Firefox/3.0.4
Reproducible: Always
| Assignee | ||
Comment 1•17 years ago
|
||
Attachment #352105 -
Flags: review?
| Assignee | ||
Updated•17 years ago
|
Flags: approval?
| Assignee | ||
Updated•17 years ago
|
Flags: approval?
| Assignee | ||
Comment 2•17 years ago
|
||
Safari shows the following:
Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10_5_5; en-us) AppleWebKit/525.27.1 (KHTML, like Gecko) Version/3.2.1 Safari/525.27.1
Is matching on 10.5 ok, or should it be 10[\._]5, to be more specific? The existing code seems to have both lax and specific patterns.
Updated•17 years ago
|
Attachment #352105 -
Flags: review? → review?(timeless)
Comment 3•17 years ago
|
||
Comment on attachment 352105 [details] [diff] [review]
Detect Mac OS X 10.5 from User-Agent string
Timeless is our OS detection code owner and guru so directing this review request to him.
Assignee: create-and-change → selsky
Status: UNCONFIRMED → ASSIGNED
Ever confirmed: true
Summary: OS sniffing doesn't detect OSX 10.5 → OS sniffing doesn't detect OS X 10.5
Comment on attachment 352105 [details] [diff] [review]
Detect Mac OS X 10.5 from User-Agent string
thanks
Attachment #352105 -
Flags: review?(timeless) → review+
Updated•17 years ago
|
Flags: approval3.2+
Flags: approval+
OS: Mac OS X → All
Hardware: x86 → All
Target Milestone: --- → Bugzilla 3.2
Comment 5•17 years ago
|
||
Comment on attachment 352105 [details] [diff] [review]
Detect Mac OS X 10.5 from User-Agent string
>+ /\(.*Intel.*Mac OS X 10.5.*\)/ && do {push @os, "Mac OS X 10.5";};
10.5 should be 10\.5, because it's a real dot.
Comment 6•17 years ago
|
||
timeless, read my previous comment.
| Assignee | ||
Comment 7•17 years ago
|
||
Escape literal . in version string as mentioned by lpsolit.
Attachment #352105 -
Attachment is obsolete: true
Attachment #354722 -
Flags: review?
| Assignee | ||
Updated•17 years ago
|
Attachment #354722 -
Flags: review? → review?(timeless)
Comment on attachment 354722 [details] [diff] [review]
Detect Mac OS X 10.5 from User-Agent string v2
no.
lpsolit should actually read the input.
Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10_5_5; en-us) AppleWebKit/525.27.1
Those aren't dots.
Attachment #354722 -
Flags: review?(timeless) → review-
Attachment #352105 -
Attachment is obsolete: false
Comment 9•17 years ago
|
||
(In reply to comment #8)
> lpsolit should actually read the input.
I was reading the input, the one from comment 0. A single dot means "any character", not only . or _.
Comment 10•17 years ago
|
||
OK, it seems you are pretty lenient about this distinction in the existing code. Let's go with the first patch.
Updated•17 years ago
|
Attachment #354722 -
Attachment is obsolete: true
Comment 11•17 years ago
|
||
tip:
Checking in enter_bug.cgi;
/cvsroot/mozilla/webtools/bugzilla/enter_bug.cgi,v <-- enter_bug.cgi
new revision: 1.165; previous revision: 1.164
done
3.2:
Checking in enter_bug.cgi;
/cvsroot/mozilla/webtools/bugzilla/enter_bug.cgi,v <-- enter_bug.cgi
new revision: 1.160.2.4; previous revision: 1.160.2.3
done
Status: ASSIGNED → RESOLVED
Closed: 17 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•