Closed Bug 46862 Opened 24 years ago Closed 24 years ago

Freeze (100% CPU Usage) trying to open Customize Search dialog

Categories

(SeaMonkey :: Search, defect, P3)

defect

Tracking

(Not tracked)

VERIFIED FIXED

People

(Reporter: bugzilla, Assigned: hyatt)

References

Details

(Keywords: crash, memory-leak, relnote, Whiteboard: [nsbeta2+])

Attachments

(2 files)

Build ID: 2000072808 WinNT4 M18

Steps to Reproduce:
(1) Switch to the Classic skin
(2) Show My Sidebar
(3) Switch to the Search tab
(4) Press the Customize... button (if there's not one, make sure the Advanced 
item is checked in Search | My Sidebar Search Panel >)

Result: Boom. (Freeze)
Severity: major → critical
Keywords: classic, crash, nsbeta3
Summary: [CLASSIC] Freeze (100% CPU Usage) trying to open Customize Search dialog → Freeze (100% CPU Usage) trying to open Customize Search dialog
Uh.

This is in the M17 branch also.  Must fix for beta2 or relnote very, very well -
- this has brought down my system on a number of occasions (of course, I'm on 
Windows so that doesn't say much...)

Not theme-dependent.
Assignee: ben → matt
Component: Themes → Search
Keywords: classicrelnote, relnote2
QA Contact: paw → claudius
Keywords: nsbeta2
Putting on [nsbeta2+] for marketing call...investigation.
Whiteboard: [nsbeta2+]
Whiteboard: [nsbeta2+] → [nsbeta2+] Confirmed Bad Bug
I just reproduced this.
The "freeze" is actually an infinite loop, acquiring emmory (I go up about a meg  
every 30 seconds :-( ).

I confirmed it on Win NT using 8/2 M17 branch build, and Leger confirmed on 
Win 95 using  8/2 M17 branch build.

The only saving grace I can see is that this happens only with "advanced search" 
turned on... and hence will impact fewer users :-/.... but it is not nice :-( 
:-(

I don't know if this is a skins problem, or something more fundamental.  
As it stands now, clicking on "customize" starts the infinite loop (with the 
freeze, meaning no handling of UI event loop anymore)
Keywords: mlk
Whiteboard: [nsbeta2+] Confirmed Bad Bug → [nsbeta2+]Confirmed blocker
More info: this is only a problem with the XUL file.  Just removed everything 
except the window tag, and it loaded.  Suspect some sort of RDF problem.  
Digging deeper...
Problem is within these lines:

  
    <tree multiple="true" flex="1" class="inset" id="allengines" 
ref="NC:SearchEngineRoot" datasources="rdf:internetsearch">
      <template>
        <treechildren>
          <treeitem uri="..." loading="rdf:http://home.netscape.com/NC-
rdf#loading">
            <treerow>
              <treecell class="treecell-indent" crop="right" 
                        src="rdf:http://home.netscape.com/NC-rdf#Icon"
                        value="rdf:http://home.netscape.com/NC-rdf#Name" />
            </treerow>
          </treeitem>
        </treechildren>
      </template>
    
      <treecolgroup>
        <treecol id="NameColumn" rdf:resource="http://home.netscape.com/NC-
rdf#Name" sortActive="true" sortDirection="ascending" flex="1"/>
      </treecolgroup>
    
      <treehead>
        <treerow>
          <treecell class="treecell-header sortDirectionIndicator outset" 
observes="NameColumn"
                    value="&allengines.label;" 
resource="http://home.netscape.com/NC-rdf#Name"
                    sortActive="true" sortDirection="ascending"
                    onclick="return doSort('NameColumn', null);" />
        </treerow>
      </treehead>

      <treechildren flex="1"/>
    </tree>

going deeper...
Sorry for the continued spam.  The problem lies within these lines:

      <template>
        <treechildren>
          <treeitem uri="..." loading="rdf:http://home.netscape.com/NC-
rdf#loading">
            <treerow>
              <treecell class="treecell-indent" crop="right" 
                        src="rdf:http://home.netscape.com/NC-rdf#Icon"
                        value="rdf:http://home.netscape.com/NC-rdf#Name" />
            </treerow>
          </treeitem>
        </treechildren>
      </template>
FIX: problem is gone by removing flex="1" from the tree tag.
cc'ing hyatt. is this related to the other problem with mail that you were
looking at yesterday? seems like we have a fairly straightforward fix, as
well...
reproduced on MacOS and linux with m17 branch bits(2000080204). Setting platform to ALL.
OS: Windows NT → All
Hardware: PC → All
My patch for the minimize infinite loop in mail also fixes this bug.
Assignee: matt → hyatt
Mtg at 4pm PST today to review all open PR2 critical bugs and will get back 
to you on a branch check in shortly after that.

Claudius, can you test with this fix ASAP?
The fix I attached is a temporary workaround.  It sounds like hyatt has the 
long-term fix. Hyatt, can you attach?
Whiteboard: [nsbeta2+]Confirmed blocker → [nsbeta2+] fix in trunk, awaiting feedback for branch
fixed everywhere.
Status: NEW → RESOLVED
Closed: 24 years ago
Resolution: --- → FIXED
*** Bug 47384 has been marked as a duplicate of this bug. ***
VERIFIED Fixed with 2000080404 -m17 nsbeta2 branch builds on all platforms x2 skins (says jrgm).

VERIFIED on trunk builds 2000080414
Status: RESOLVED → VERIFIED
Whiteboard: [nsbeta2+] fix in trunk, awaiting feedback for branch → [nsbeta2+]
Product: Core → SeaMonkey
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: