468658 - show "no match" text when there are no autocomplete results

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[:Gavin Sharp [email: [e-mail]]]

Per bug 460100 comment 4.

> Yeah, let's make sure we put in a "No matches" message if there are no matches.
> Horizontally entered and on row two or three, vertically.

Comment 1

[:Gavin Sharp [email: [e-mail]]]

Attachment: patch

I'll file a bug for the getElementsByTagName failure I was seeing (though it might be a dupe).

Also fixes bug 486656.

Comment 2

[:Gavin Sharp [email: [e-mail]]]

-had to add the label="" for the label to take space layout-wise (hope it doesn't affect perf!)
-used attribute/dtd rather than a stringbundle to avoid the overhead (DTD was already being loaded)
-got ui-r from madhava in-person on the "no results" styling

Comment 3

[Mark Finkle (:mfinkle) (use needinfo?)]

Comment on attachment 379603 [details] [diff] [review]
patch

italic? :)

Comment 4

[:Gavin Sharp [email: [e-mail]]]

Beltzner suggested that, actually, to better differentiate it from a normal result, and madhava and I are not italic-haters.

https://hg.mozilla.org/mobile-browser/rev/632e7d859cbc

Comment 5

[Aakash Desai [:aakashd]]

verified FIXED On builds:

Mozilla/5.0 (Windows; U; WindowsCE 5.2; en-US; rv:1.9.3a1pre) Gecko/20090818 Fennec/1.0a3pre

and

Mozilla/5.0 (X11; U; Linux armv6l; en-US; rv:1.9.3a1pre) Gecko/20090821
Fennec/1.0b3pre

and

Mozilla/5.0 (Macintosh; U; Intel Mac OSX 10.5; en-US; rv:1.9.2a2pre)
Gecko/20090808 Fennec/1.0b3pre