468774 - Preference window incorrectly shows default font

Status: RESOLVED FIXED

(Thunderbird :: Preferences, defect)

Description

[Daniel]

User-Agent:       Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9.0.4) Gecko/2008111318 Ubuntu/8.10 (intrepid) Firefox/3.0.4
Build Identifier: Ubuntu 8.10

The preference window does not show the user-chosen default font; only "variable width".  However, the user-chosen font is used when composing a new message.

Reproducible: Always

Steps to Reproduce:
1. Change the default HTML font from "Variable width" to something else
2. Close the preferences window
3. Open the preferences window
Actual Results:  
"Variable width" is displayed as the chosen font

Expected Results:  
Another font "Arial", "Times New Roman", etc should be shown as the chosen font

Comment 1

[David :Bienvenu]

this is pretty broken...

Comment 2

[YUKI "Piro" Hiroshi]

I also saw same problem on Thunderbird 2.0.0.x. On Shredder (trunk), no item is chosen instead of "Variable width".

The problem is caused by processes like following:
1. The preferences dialog is loaded. The menulist only have few built-in items,
   "Variable width", "Fixed width", etc.
2. <preference> tries to choose the menu item for "Arial". But there is no
   <menuitem> for the font. So, <preference> does nothing.
3. <prefpane> fires "paneload" event and gComposePane.init() is called.
   The list of installed fonts are generated by gComposePane.populateFonts().

To fix this bug, we have to generate the list of fonts before <preference>'s choosing.

Comment 3

[YUKI "Piro" Hiroshi]

Or, choosing menuitem again by populateFonts() can fix it too.

Comment 4

[YUKI "Piro" Hiroshi]

Attachment: Patch for Shredder (ver.1.0)

Comment 5

[YUKI "Piro" Hiroshi]

Attachment: Patch for Thunderbird 2.0.0.x (ver.1.0)

Comment 6

[David :Bienvenu]

Comment on attachment 356635 [details] [diff] [review]
Patch for Shredder (ver.1.0)

thx for the patch - I'll land this.

Comment 7

[David :Bienvenu]

Comment on attachment 356636 [details] [diff] [review]
Patch for Thunderbird 2.0.0.x (ver.1.0)

requesting approval for next 2.0x build - trivial fix. (no guarantee that we'll take this but it doesn't hurt to ask)

Comment 8

[David :Bienvenu]

fix on trunk for Shredder

Comment 9

[Dan Mosedale (:dmosedale, :dmose)]

Comment on attachment 356636 [details] [diff] [review]
Patch for Thunderbird 2.0.0.x (ver.1.0)

We have too few resources to introduce any risk into the branch for patches which are not security or stability problems.  Unfortunately, this doesn't qualify as either of those.  Apologies.