468781 - gcc complaing about comparing char* with string literal

Status: RESOLVED FIXED

(Core :: DOM: Events, defect)

Description

[Wolfgang Rosenauer [:wolfiR]]

Attachment: possible patch

http://mxr.mozilla.org/mozilla-central/source/content/events/src/nsDOMDataTransfer.cpp#721

706   const char* formats[] = { kFileMime, kHTMLMime, kURLMime, kURLDataMime, kUnicodeMime };

721         if (formats[f] == kUnicodeMime) {
722           SetDataWithPrincipal(NS_LITERAL_STRING("text/plain"), nsnull, c, sysPrincipal);
723         }
724         else {
725           if (formats[f] == kURLDataMime)

gcc doesn't like that and openSUSE's public buildsystem breaks the complete build because that type of warning is fatal there.

Comment 1

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Ouch, that is a bad bug.

However, this is also a bad bug:
+          if (strcmp(formats[f], kURLDataMime == 0))

The == 0 should not be inside the second parameter...

Comment 2

[Wolfgang Rosenauer [:wolfiR]]

Attachment: fixed patch

oO, my original patch is correct, that's what happens if you don't do cut'n'paste. Sorry.

Comment 3

[Wolfgang Rosenauer [:wolfiR]]

Pushed to mozilla-central.
Waiting for 1.9.1 approval

Comment 4

[Mike Beltzner [:beltzner, not reading bugmail]]

Comment on attachment 352496 [details] [diff] [review]
fixed patch

a191=beltzner

Comment 5

[Wolfgang Rosenauer [:wolfiR]]

Pushed to 1.9.1