468804 - make pointer from integer in g_object_set_data() calls

Status: RESOLVED FIXED

(Core :: Widget: Gtk, defect)

Description

[Wolfgang Rosenauer [:wolfiR]]

Attachment: possible patch

Building 1.9.1 I get the following warnings from gcc (they are breaking the build as fatal in the public openSUSE buildsystem):

warning: passing argument 3 of 'g_object_set_data' makes pointer from integer without a cast

I see how that seems to work but it still seems to be not fully right.

Comment 1

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Comment on attachment 352287 [details] [diff] [review]
possible patch

Thanks Wolfgang! (and hi!)

Comment 2

[Wolfgang Rosenauer [:wolfiR]]

committed to mozilla-central

(waiting for 1.9.1 approval)

Comment 3

[Mike Beltzner [:beltzner, not reading bugmail]]

Comment on attachment 352287 [details] [diff] [review]
possible patch

a191=beltzner

Comment 4

[Wolfgang Rosenauer [:wolfiR]]

http://hg.mozilla.org/releases/mozilla-1.9.1/rev/f00763682e5e