If you think a bug might affect users in the 57 release, please set the correct tracking and status flags for Release Management.

libosso.h and hildon-uri.h should be defined in system-headers list

RESOLVED FIXED

Status

()

Core
Build Config
RESOLVED FIXED
9 years ago
9 years ago

People

(Reporter: romaxa, Assigned: romaxa)

Tracking

Trunk
x86
Linux
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 1 obsolete attachment)

(Assignee)

Description

9 years ago
Created attachment 352305 [details] [diff] [review]
Build fix

libosso.h and hildon-uri.h should be defined in system-headers list
http://mxr.mozilla.org/mozilla-central/source/uriloader/exthandler/unix/nsMIMEInfoUnix.cpp#42
http://mxr.mozilla.org/mozilla-central/source/toolkit/xre/nsNativeAppSupportUnix.cpp#61
Attachment #352305 - Flags: review?(benjamin)
Assignee: nobody → romaxa

Updated

9 years ago
Attachment #352305 - Flags: review?(benjamin) → review+
(Assignee)

Comment 1

9 years ago
Fixed in:
http://hg.mozilla.org/mozilla-central/rev/12f97a5bc3b6
Status: NEW → RESOLVED
Last Resolved: 9 years ago
Resolution: --- → FIXED
This is causing tinderbox orange because it made config/system-headers and js/src/config/system-headers different.
Backed out.
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
(Assignee)

Comment 4

9 years ago
Created attachment 352696 [details] [diff] [review]
Added same fix for JS system-headers
Attachment #352305 - Attachment is obsolete: true
Attachment #352696 - Flags: review?(benjamin)
I don't think you need re-review to copy the same changes to js/src/config. I'd say just check it in since you already got review on the original changes.
(Assignee)

Comment 6

9 years ago
Pushed in:
http://hg.mozilla.org/mozilla-central/rev/eff859d08302
(Assignee)

Comment 7

9 years ago
Fixed
Status: REOPENED → RESOLVED
Last Resolved: 9 years ago9 years ago
Resolution: --- → FIXED

Updated

9 years ago
Attachment #352696 - Flags: review?(benjamin)
You need to log in before you can comment on or make changes to this bug.