468836 - Existing tags no longer show and cannot be edited

Status: VERIFIED FIXED

(Firefox :: Bookmarks & History, defect, P1)

Description

[Jim Jeffery not reading bug-mail 1/2/11]

Starting with the build on 12/10/2008 trunk nightly opening the Bookmarks Library, existing bookmarks with 'tags' no longer show / and cannot be edited in the lower right-pane. 

1.  Open the library
2.  Select a bookmark with a 'tag' 
3.  note that in the lower right-pane in the 'tags drop list' there are no tags showing, and therefore cannot remove the tag. 

It was noted on IRC :
 i think the issue happens after you select folders/separators in the library and then go to a tagged item

Comment 1

[Marco Bonardo [:mak]]

i was seeing this, but after some time i did not see it anymore... so it' not a continue issue but something that happens. We for sure need some good STR, i was thinking to a regression from bug 461855 but if so, it should be visible in previous nightlies from 08 Dec. on

Comment 2

[Marco Bonardo [:mak]]

did you lose any tag or they simply don't show in the dialog (since that's what i was seeing)?

Comment 3

[Marco Bonardo [:mak]]

oh and sometimes i was seeing graphic garbage in the field (part of the tag name)

Comment 4

[Jim Jeffery not reading bug-mail 1/2/11]

reply to comment #2, no tags were not lost per se` , just not visible in the lower right-pane.  Maybe the dataloss keyword is too strong...


    I was wrong, today's nightly is OK using buildset:
    http://hg.mozilla.org/mozilla-central/rev/29f1fa84f8fd

    I believe its broken in changeset:
    http://hg.mozilla.org/mozilla-central/rev/9952fee851da

Retesting with latest hourly..

Comment 5

[Jim Jeffery not reading bug-mail 1/2/11]

Yes, confirmed, broken in changeset: 
 http://hg.mozilla.org/mozilla-central/rev/9952fee851da

Comment 6

[Marco Bonardo [:mak]]

i suspect is instead http://hg.mozilla.org/mozilla-central/rev/89a175c70c25 pushed at the same time, taggging service change from bug 463513

Comment 7

[Marco Bonardo [:mak]]

i can confirm removing tagging service changes fixes the issue, so this is a regression to be fixed before next nightly.

Comment 8

[Marco Bonardo [:mak]]

Attachment: patch

we should go back to the folder node, that's because RESULTS_AS_TAG_QUERY actually does not return any itemId (queries are built on-the-fly) so we can't do child.itemId, we should instead use getConcreteItemId, but since PlacesUtils is not included (and i don't think we want to import it only for this) it's better going back for now)

it's a pity our tests did not get this, i'm looking if i can add a test for previously existing tags before asking a review.

Comment 9

[Marco Bonardo [:mak]]

Attachment: patch v1.1

ok this comes with a unit test, i've done some cleanup in the test while there.

Comment 10

[Dietrich Ayala (:dietrich)]

Comment on attachment 352332 [details] [diff] [review]
patch v1.1

r=me, thanks!

Comment 11

[Marco Bonardo [:mak]]

pushed to trunk:
http://hg.mozilla.org/mozilla-central/rev/523bdc086002

Comment 12

[Robert Sayre]

Had to back this out due to persistent orange. Please try again when the tree is green.

Comment 13

[Marco Bonardo [:mak]]

note: this is not the cause of the orange and was pushed on green tree, unlucky the patch that caused orange was pushed a few minutes before this.

Comment 14

[Marco Bonardo [:mak]]

pushed again on trunk:
http://hg.mozilla.org/mozilla-central/rev/2c82db5dff7a

Comment 15

[Jim Jeffery not reading bug-mail 1/2/11]

Verified fixed using changeset: 
http://hg.mozilla.org/mozilla-central/rev/6f34b3d7748d

Hourly build: 
Mozilla/5.0 (Windows; U; Windows NT 6.0; en-US; rv:1.9.2a1pre) Gecko/20081211 Minefield/3.2a1pre Firefox/3.0.4 ID:20081211084445

Comment 16

[Shawn Wilsher :sdwilsh]

http://hg.mozilla.org/releases/mozilla-1.9.1/rev/bc7ef61db0cd

Comment 17

[Aakash Desai [:aakashd]]

verified FIXED on Shiretoko: Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.5; en-US; rv:1.9.1b3) Gecko/20090305 Firefox/3.1b3 ID:20090305133223