468891 - Microsummary sync is flaky

Status: RESOLVED FIXED

(Cloud Services :: General, defect)

Description

[Dan Mills [:thunder]]

I've seen problems with microsummaries in my tests, but am not sure what the problem really is.  I was trying to set the title manually (effectively making it not a microsummary anymore).  It seems to sync up fine, but after that a sync on a 2nd machine fails, and then a sync on the 1st machine again fails too:

2008-12-10 11:40:09     Store.BStore    TRACE   Editing item 5363
2008-12-10 11:40:09     Service.Util    DEBUG   Could not create URI: [Exception... "Component returned failure code: 0x804b000a (NS_ERROR_MALFORMED_URI) [nsIIOService.newURI]"  nsresult: "0x804b000a (NS_ERROR_MALFORMED_URI)"  location: "JS frame :: file:///.../modules/util.js :: Weave_makeURI :: line 329"  data: no]

2008-12-10 11:40:09     Service.BmkEngine       WARN    Sync failed
2008-12-10 11:40:09     Service.Main    WARN    Engine exception: [Exception... "Component returned failure code: 0x80520012 (NS_ERROR_FILE_NOT_FOUND) [nsIXMLHttpRequest.send]"  nsresult: "0x80520012 (NS_ERROR_FILE_NOT_FOUND)"  location: "JS frame :: file:///.../nsMicrosummaryService.js :: MSR_load :: line 2014"  data: no]
2008-12-10 11:40:09     FaultTolerance  DEBUG   Original exception: Component returned failure code: 0x80520012 (NS_ERROR_FILE_NOT_FOUND) [nsIXMLHttpRequest.send] (JS frame :: file:///Users/thunder/Apps/Minefield.app/Contents/MacOS/components/nsMicrosummaryService.js :: MSR_load :: line 2014)

Comment 1

[Ed Lee :Mardak]

Bug 488170 fixes this probably with these 2 lines:
http://hg.mozilla.org/labs/weave/rev/31978e0b2df8#l23
getBookmarkURI returns a nsIURI, so no need to call makeURI

http://hg.mozilla.org/labs/weave/rev/31978e0b2df8#l48
We were putting a nsIURI into the cleartext, so JSON.stringify probably ignored it

When I tested, syncing the microsummary the first time produced an error in the error console saying that generatorURI is undefined -- JSON.parse probably didn't even have a record for it.