Status
People
(Reporter: samuel.sidler+old, Assigned: rdoherty)
Tracking
Firefox Tracking Flags
(Not tracked)
Details
Attachments
(2 attachments)
|
539 bytes,
patch
|
Details | Diff | Splinter Review | |
|
378 bytes,
text/plain
|
samuel.sidler+old
:
review+
|
Details |
Compare: http://www.mozilla.com/en-US/firefox/3.0.5/whatsnew/ To: http://www-trunk.stage.mozilla.com/en-US/firefox/3.0.5rc/whatsnew/ The former is correct, the latter is wrong. But on: http://www-trunk.stage.mozilla.com/en-US/firefox/2.0.0.19/whatsnew/ We want it to look right. On: https://www.mozilla.com/en-US/firefox/2.0.0.19/whatsnew/ You can see it looks wrong. Steven? Wil? This is bad UI and definitely blocks the release, maybe beta. Need to talk to QA.
|
(Reporter) | |
Updated•10 years ago
|
||
Summary: CSS issue on whatsnew pages on trunk → CSS issue on whatsnew pages
|
(Assignee) | |
Comment 2•10 years ago
|
||
Created attachment 352405 [details] [diff] [review] Patch for the 2.0.0.19 page Adding this code to whatsnew-page.css fixes the 2.0.0.19 issues for me. Not sure about the 3.0.5 stuff yet.
Attachment #352405 -
Flags: review?(samuel.sidler)
|
|
(Assignee) | |
Comment 3•10 years ago
|
||
Created attachment 352408 [details]
Fix for 3.0.5 page
Here's the code for the 3.0.5 page. It should be added to whatsnew-page.css
needs some qa to verify it doesn't affect other pages.
Attachment #352408 -
Flags: review?(samuel.sidler)
|
|
(Reporter) | |
Comment 4•10 years ago
|
||
Comment on attachment 352408 [details]
Fix for 3.0.5 page
This works for me on 3.0.5 and doesn't cause any problems on 2.0.0.19. I'm landing it now. This CSS shouldn't be included in other files.
Attachment #352408 -
Flags: review?(samuel.sidler) → review+
|
|
(Reporter) | |
Comment 5•10 years ago
|
||
Comment on attachment 352405 [details] [diff] [review] Patch for the 2.0.0.19 page This is already included afaict and is not needed to fix this bug.
Attachment #352405 -
Flags: review?(samuel.sidler)
|
|
(Reporter) | |
Updated•10 years ago
|
||
Assignee: nobody → rdoherty
|
|
(Reporter) | |
Comment 6•10 years ago
|
||
Landed and pushed to production.
Status: NEW → RESOLVED
Last Resolved: 10 years ago
Resolution: --- → FIXED
|
||
Comment 7•10 years ago
|
||
Looking good on http://www-trunk.stage.mozilla.com/en-US/firefox/2.0.0.19/whatsnew/ and https://www-trunk.stage.mozilla.com/en-US/firefox/3.0.5rc/whatsnew/; waiting for them to hit prod, and I'll verify.
|
|
||
Comment 8•10 years ago
|
||
https://www.mozilla.com/en-US/firefox/2.0.0.19/whatsnew/ https://www.mozilla.com/en-US/firefox/3.0.5rc/whatsnew/ Verified FIXED.
Status: RESOLVED → VERIFIED
|
||
Updated•7 years ago
|
||
Component: www.mozilla.org/firefox → www.mozilla.org
Product: Websites → Websites
|
|
||
Updated•6 years ago
|
||
Component: www.mozilla.org → General
Product: Websites → www.mozilla.org
You need to log in
before you can comment on or make changes to this bug.
Description
•