468990 - CSS issue on whatsnew pages

Status: VERIFIED FIXED

(www.mozilla.org :: General, defect)

Description

[Samuel Sidler (old account; do not CC)]

Compare: http://www.mozilla.com/en-US/firefox/3.0.5/whatsnew/
To: http://www-trunk.stage.mozilla.com/en-US/firefox/3.0.5rc/whatsnew/

The former is correct, the latter is wrong.

But on: http://www-trunk.stage.mozilla.com/en-US/firefox/2.0.0.19/whatsnew/
We want it to look right.

On: https://www.mozilla.com/en-US/firefox/2.0.0.19/whatsnew/
You can see it looks wrong.

Steven? Wil? This is bad UI and definitely blocks the release, maybe beta. Need to talk to QA.

Comment 1

[Wil Clouser [:clouserw]]

Steven, is this r20405?

Comment 2

[Ryan Doherty (:rdoherty)]

Attachment: Patch for the 2.0.0.19 page

Adding this code to whatsnew-page.css fixes the 2.0.0.19 issues for me. Not sure about the 3.0.5 stuff yet.

Comment 3

[Ryan Doherty (:rdoherty)]

Attachment: Fix for 3.0.5 page

Here's the code for the 3.0.5 page. It should be added to whatsnew-page.css

needs some qa to verify it doesn't affect other pages.

Comment 4

[Samuel Sidler (old account; do not CC)]

Comment on attachment 352408 [details]
Fix for 3.0.5 page

This works for me on 3.0.5 and doesn't cause any problems on 2.0.0.19. I'm landing it now. This CSS shouldn't be included in other files.

Comment 5

[Samuel Sidler (old account; do not CC)]

Comment on attachment 352405 [details] [diff] [review]
Patch for the 2.0.0.19 page

This is already included afaict and is not needed to fix this bug.

Comment 6

[Samuel Sidler (old account; do not CC)]

Landed and pushed to production.

Comment 7

[Stephen Donner [:stephend] Not actively reading bugmail]

Looking good on http://www-trunk.stage.mozilla.com/en-US/firefox/2.0.0.19/whatsnew/ and https://www-trunk.stage.mozilla.com/en-US/firefox/3.0.5rc/whatsnew/; waiting for them to hit prod, and I'll verify.

Comment 8

[Stephen Donner [:stephend] Not actively reading bugmail]

https://www.mozilla.com/en-US/firefox/2.0.0.19/whatsnew/
https://www.mozilla.com/en-US/firefox/3.0.5rc/whatsnew/

Verified FIXED.