jcmarker.c(658) : warning C4028: formal parameter 2 different from declaration

RESOLVED FIXED in mozilla1.9.3a1

Status

()

defect
RESOLVED FIXED
11 years ago
10 years ago

People

(Reporter: timeless, Assigned: timeless)

Tracking

Trunk
mozilla1.9.3a1
x86
Windows XP
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

Assignee

Description

11 years ago
c:/home/mozilla.org/mozilla-central/jpeg/jcmarker.c(658) : warning C4028: formal parameter 2 different from declaration
c:/home/mozilla.org/mozilla-central/jpeg/jcmarker.c(659) : warning C4028: formal parameter 2 different from declaration

http://mxr-test.konigsberg.mozilla.org/mozilla-central/source/jpeg/jpegint.h?rev=29f1fa84f8fd&mark=128-130#118
128   JMETHOD(void, write_marker_header, (j_compress_ptr cinfo, int marker,
129                                       unsigned int datalen));
130   JMETHOD(void, write_marker_byte, (j_compress_ptr cinfo, int val));

http://mxr-test.konigsberg.mozilla.org/mozilla-central/source/jpeg/jcmarker.c?rev=29f1fa84f8fd&mark=435-436,447-448,658-659#430
METHODDEF(void)
write_marker_header (j_compress_ptr cinfo, int16 marker, unsigned int datalen)

METHODDEF(void)
write_marker_byte (j_compress_ptr cinfo, int16 val)

  marker->pub.write_marker_header = write_marker_header;
  marker->pub.write_marker_byte = write_marker_byte;

int16 and int aren't really the same
Attachment #352402 - Flags: review?
You have a patch on this bug that is flagged for 'review?' and not assigned to any reviewer. If you want the patch to be reviewed please assign a reviewer. Thanks
Comment on attachment 352402 [details] [diff] [review]
change impl to match prototype

I need for symbian emulator build.  (jsmaker.c causes build error on Symbian's code warrior compiler).
Attachment #352402 - Flags: review? → review?(joe)
Attachment #352402 - Flags: review?(joe) → review+
Dunno how you expect me to wipe your checkin-needed if you don't even assign the bugs you patch to yourself.
Assignee: nobody → timeless
Keywords: checkin-needed
http://hg.mozilla.org/mozilla-central/rev/6956e3df30f5
Status: NEW → RESOLVED
Last Resolved: 10 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → mozilla1.9.3a1
You need to log in before you can comment on or make changes to this bug.