468994 - jcmarker.c(658) : warning C4028: formal parameter 2 different from declaration

Status: RESOLVED FIXED

(Core :: Graphics: ImageLib, defect)

Description

[timeless]

Attachment: change impl to match prototype

c:/home/mozilla.org/mozilla-central/jpeg/jcmarker.c(658) : warning C4028: formal parameter 2 different from declaration
c:/home/mozilla.org/mozilla-central/jpeg/jcmarker.c(659) : warning C4028: formal parameter 2 different from declaration

http://mxr-test.konigsberg.mozilla.org/mozilla-central/source/jpeg/jpegint.h?rev=29f1fa84f8fd&mark=128-130#118
128   JMETHOD(void, write_marker_header, (j_compress_ptr cinfo, int marker,
129                                       unsigned int datalen));
130   JMETHOD(void, write_marker_byte, (j_compress_ptr cinfo, int val));

http://mxr-test.konigsberg.mozilla.org/mozilla-central/source/jpeg/jcmarker.c?rev=29f1fa84f8fd&mark=435-436,447-448,658-659#430
METHODDEF(void)
write_marker_header (j_compress_ptr cinfo, int16 marker, unsigned int datalen)

METHODDEF(void)
write_marker_byte (j_compress_ptr cinfo, int16 val)

  marker->pub.write_marker_header = write_marker_header;
  marker->pub.write_marker_byte = write_marker_byte;

int16 and int aren't really the same

Comment 1

[Murali Nandigama [:murali]]

You have a patch on this bug that is flagged for 'review?' and not assigned to any reviewer. If you want the patch to be reviewed please assign a reviewer. Thanks

Comment 2

[Makoto Kato [:m_kato]]

Comment on attachment 352402 [details] [diff] [review]
change impl to match prototype

I need for symbian emulator build.  (jsmaker.c causes build error on Symbian's code warrior compiler).

Comment 3

[Phil Ringnalda (:philor)]

Dunno how you expect me to wipe your checkin-needed if you don't even assign the bugs you patch to yourself.

Comment 4

[Phil Ringnalda (:philor)]

http://hg.mozilla.org/mozilla-central/rev/6956e3df30f5