469019 - gfxRect shouldn't be forward declared as a class

Status: RESOLVED FIXED

(Core Graveyard :: GFX, defect)

Description

[timeless]

c:\home\mozilla.org\mozilla-central\dbg-firefox-i686-pc-mingw32\dist\include\thebes\gfxRect.h(57) : warning C4099: 'gfxRect' : type name first seen using 'class' now seen using 'struct'
        c:\home\mozilla.org\mozilla-central\dbg-firefox-i686-pc-mingw32\dist\include\gfx\nsIImage.h(48) : see declaration of 'gfxRect'
nsXULElement.cpp
Building deps for /c/home/mozilla.org/mozilla-central/content/xul/content/src/nsXULElement.cpp
c:\home\mozilla.org\mozilla-central\dbg-firefox-i686-pc-mingw32\dist\include\thebes\gfxMatrix.h(67) : warning C4099: 'gfxMatrix' : type name first seen using 'class' now seen using 'struct'
        c:\home\mozilla.org\mozilla-central\dbg-firefox-i686-pc-mingw32\dist\include\gfx\nsIImage.h(47) : see declaration of 'gfxMatrix'


Defined as a function in:
    * gfx/thebes/public/gfxRect.h (View CVS log or CVS annotations) (View Hg log or Hg annotations)
57 struct THEBES_API gfxRect {
          o line 63 -- gfxRect(const gfxRect& s) : pos(s.pos), size(s.size) {}
          o line 64 -- gfxRect(const gfxPoint& _pos, const gfxSize& _size) : pos(_pos), size(_size) {}
          o line 65 -- gfxRect(gfxFloat _x, gfxFloat _y, gfxFloat _width, gfxFloat _height) : 

Defined as a struct type in:

    * layout/svg/base/src/nsSVGUtils.h (View CVS log or CVS annotations) (View Hg log or Hg annotations)
          o line 74 -- struct gfxRect; 

Defined as a (forwarded) class in:

    * gfx/public/nsIImage.h (View CVS log or CVS annotations) (View Hg log or Hg annotations)
          o line 48 -- class gfxRect;

Comment 1

[timeless]

Attachment: switch from class to struct

Comment 2

[Robert Longson [:longsonr]]

gfxMatrix is a struct too.

Comment 3

[timeless]

Attachment: oops, incomplete patch/bug [Checkin: Comment 5]

Comment 5

[Serge Gautherie (:sgautherie)]

Comment on attachment 352513 [details] [diff] [review]
oops, incomplete patch/bug
[Checkin: Comment 5]

http://hg.mozilla.org/mozilla-central/rev/635d4b7f26cb