469075 - WinCE Shunt Build Layout Too Complicated

Status: VERIFIED DUPLICATE of bug 474737

(Core :: General, defect)

Description

[John Wolfe (:wolfe)]

Attachment: v1.0 patch

Right now, there are two copies of all the tools needed for building the WinCE / WinMobile 6 XULRunner and Fennec.  The only difference between those two versions of tools is one line in a header file.

Also, the Visual Studio projects needed to build the mozce_shunt.dll library have way too many platform types that are not being actively developed (2003 PPC and Smartphone, WM5 PPC and Smartphone, Debug and Release versions of everything).

As the mozce_shunt Visual Studio projects are laid out right now, a new clone of mozilla-central will fail to properly build the mozce_shunt from within Visual Studio.

For these reasons, the WinCE / WinMobile 6 compilation and linking tools source code and mozce_shunt building code should be trimmed down, which will make them both more maintainable.

Comment 1

[Doug Turner (:dougt)]

Comment on attachment 352484 [details] [diff] [review]
v1.0 patch

in meetings this week -- brad can you swing at this review.  otherwise, let me know and I can get to it next week.

Comment 2

[Brad Lassey [:blassey] (use needinfo?)]

John, instead of deleting the existing tools and creating new ones, it would be useful to use hg rename.

Comment 3

[Brad Lassey [:blassey] (use needinfo?)]

This is actually cleaning up the tools which was fixed in bug 474373

Comment 4

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Brad, I'm sure you entered the wrong bug number. I cant see any correlation between this bug and bug 474373 which is about MozMill.

Comment 5

[John Wolfe (:wolfe)]

This is actually cleaning up the tools, which was fixed in BUG 474737 -- not 474373.

Comment 6

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Yeah. That's much better. Verified.