469085 - Add manifest to 7zSD.sfx

Status: RESOLVED FIXED

(SeaMonkey :: Installer, defect)

Description

[Robert Strong (they/them - no direct email)]

This has been done for Firefox / Thunderbird and I thought Seamonkey as well. It should contain the following... this will launch the 7-zip stub without elevation on Vista and then NSIS will request elevation.

<assembly xmlns="urn:schemas-microsoft-com:asm.v1" manifestVersion="1.0">
<assemblyIdentity version="1.0.0.0" processorArchitecture="X86" name="7zS.sfx.exe" type="win32"></assemblyIdentity>
<description>7-Zip Self-extracting Archive v4.42</description>
<dependency>
<dependentAssembly>
<assemblyIdentity type="win32" name="Microsoft.Windows.Common-Controls" version="6.0.0.0" processorArchitecture="X86" publicKeyToken="6595b64144ccf1df" language="*"></assemblyIdentity>
</dependentAssembly>
</dependency>
<trustInfo xmlns="urn:schemas-microsoft-com:asm.v3"><security><requestedPrivileges><requestedExecutionLevel level="asInvoker" uiAccess="false"></requestedExecutionLevel></requestedPrivileges></security>
</trustInfo>
</assembly>

Comment 1

[Robert Strong (they/them - no direct email)]

Attachment: patch

Frank, could I get you to review this? To see the change to the binary you'll need reshacker ( http://www.angusj.com/resourcehacker/ ) and the addition is resource 24. I'll also attach the binary.

Comment 2

[Robert Strong (they/them - no direct email)]

Attachment: Update 7-Zip stub

Comment 3

[Frank Wein [:mcsmurf]]

Comment on attachment 352499 [details] [diff] [review]
patch

Oh right, I forgot to change the manifest to match the new installer code. Patch looks good and seems to work fine, r+.

Comment 4

[Robert Strong (they/them - no direct email)]

Frank, shall I land this on both trunk and 1.9.1?

Comment 5

[Frank Wein [:mcsmurf]]

Yeah, do it that way.

Comment 6

[Robert Strong (they/them - no direct email)]

Pushed to mozilla-central
http://hg.mozilla.org/mozilla-central/rev/23e4c322ac1bd3b57e9b6893165dad348699ca4f

Pushed to mozilla-1.9.1
http://hg.mozilla.org/releases/mozilla-1.9.1/rev/3cf1487f59ab