469090 - Editing vcard info on identity of email account starts with empty form

Status: RESOLVED FIXED

(MailNews Core :: Address Book, defect)

Description

[fritz.heinrichmeyer]

User-Agent:       Mozilla/5.0 (X11; U; Linux x86_64; de; rv:1.9.0.4) Gecko/2008111319 Ubuntu/8.10 (intrepid) Firefox/3.0.4
Build Identifier: Mozilla/5.0 (X11; U; Linux i686 (x86_64); de; rv:1.9.1b3pre) Gecko/20081204 Lightning/1.0pre Thunderbird/3.0b1


Even when there is already vcard info in use when sending mail, the vcard dialog shows empty entries, so i have to insert all information from scratch.


Reproducible: Always

Steps to Reproduce:
1. create vcard entry
2. send mail with vcard attachment
3 [review]. try to edit your attached vcard information
Actual Results:  
vcard forms are empty

Expected Results:  
vcard forms should show old entries

Comment 1

[Mark Banner (:standard8)]

I see this, regression from bug 63941. Wayne, we definitely need litmus tests for the vcard editing in account manager - whenever we do a change to AB cards, we tend to break it.

Comment 2

[Mark Banner (:standard8)]

Attachment: The fix

The problem is that we're collapsing an element that is no longer in the dialog. I'm not sure why this isn't getting to the error console, I guess something somewhere is catching it.

Anyway, the solution is to replace by elements that are there, and define a few extra ids so that we can easily do this.

Comment 3

[[e-mail]]

Comment on attachment 352509 [details] [diff] [review]
The fix

homeTabButton needs to be hidden, not collapsed, while abHomeTab should be neither collapsed nor hidden. (The other elements probably don't care.)

Comment 4

[Mark Banner (:standard8)]

Attachment: The fix v2

Revised as per Neil's suggestions

Comment 5

[Wayne Mery (:wsmwk)]

(In reply to comment #1)
> I see this, regression from bug 63941. Wayne, we definitely need litmus tests
> for the vcard editing in account manager - whenever we do a change to AB cards,
> we tend to break it.

vcard is https://litmus.mozilla.org/show_test.cgi?id=5487 in FFT, subgroup 919 Mail composition. It seems vague.  Also, perhaps a piece needs to be added to account settings subgroup 923.  Setting in-litmus? so we follow up with this. And adding note to postmortem that we will want to do FFT for beta 2.

Comment 6

[Mark Banner (:standard8)]

(In reply to comment #5)
> Setting in-litmus? so we follow up with this.

Yes, thanks - I set the wrong flag earlier.

Comment 7

[Mark Banner (:standard8)]

Patch checked in: http://hg.mozilla.org/comm-central/rev/c4e08d2741fc

Comment 9

[Ludovic Hirlimann [:Usul]]

(In reply to comment #5)
> (In reply to comment #1)

> vcard is https://litmus.mozilla.org/show_test.cgi?id=5487 in FFT, subgroup 919
> Mail composition. It seems vague.  Also, perhaps a piece needs to be added to
> account settings subgroup 923.  Setting in-litmus? so we follow up with this.
> And adding note to postmortem that we will want to do FFT for beta 2.

Agreed that one should be split in more than one TC.

Comment 10

[Ludovic Hirlimann [:Usul]]

https://litmus.mozilla.org/show_test.cgi?id=7758