469095 - Error Notice: this variable may not be empty: $_POST["username"] when clicking "Switch" button

Status: VERIFIED DUPLICATE of bug 463719

(support.mozilla.org :: General, defect)

Description

[Stephen Donner [:stephend] Not actively reading bugmail]

Steps to Reproduce:

1. Ensure you're logged out.
2. Load https://support-stage.mozilla.org/tiki-login_scr.php
3. Log in
4. Click Firefox's "Back" button
5. Press the "Switch" button without entering anything

Expected Results:

Actual Results:

"Error

Notice: this variable may not be empty: $_POST["username"]"

Seems bad...(at least remove the notice!)

(I think this bug might occur because of the way Firefox implements its BFCache (back-forward cache, which doesn't resubmit POSTs, iirc).

Comment 1

[Stephen Donner [:stephend] Not actively reading bugmail]

FWIW, I'm not presented with the user-switching UI on prod, so don't know if the UI that includes the "Switch" button in comment 5 is intended or not; assuming so?

Comment 2

[Chris Ilias [:cilias]]

IIRC, the switch feature only appears for admins.

Comment 3

[E. Cooper [:ecooper]]

FYI, this message is produced by a function built into tiki-setup_base.php. It's just a variable check that makes sure certain params aren't empty (obviously ;). I agree that the generic message makes it sound like the sky has fallen instead of a field just being empty.

I'm also under the impression only admins can access the switch feature.

Comment 4

[Laura Thomson :laura]

Resolved as part of the fix for https://bugzilla.mozilla.org/show_bug.cgi?id=463719

Comment 5

[Stephen Donner [:stephend] Not actively reading bugmail]

Verified dup