46911 - [Classic] url bar not inheriting Windows colors

Status: VERIFIED DUPLICATE of bug 57429

(SeaMonkey :: Themes, defect, P3)

Description

[fantasai]

Overiview:

	I changed the appearance colors on my system drastically; green/white 	
	text on black/dark blue background. In Mozilla, the background in the 
	URL bar remained white, while the actual text field (the part where you 
	can type) changed to black. But the text in the text field remained 
	black, so the URL was unreadable.

Steps to Reproduce:

	1) Go to Start > Settings > Control Panel > Display > Appearance
	2) Change 'Window' item settings to green text on a black background
	3) Open Mozilla and switch to the Classic skin, if necessary

Expected Results:

	Black URL bar & text field, green text

Actual Results:

	White URL bar, black text field, black text

Tested on Mozilla nightly build (id: 2000072810) on Windows 2000 and several 
previous builds.

Additional comments:

	I don't know if this is the right component.

Comment 1

[Blake Ross]

Is this problem isolated to the classic skin? Or does it happen with the modern 
skin as well?

Comment 2

[fantasai]

Yes, it's isolated to the classic skin; it's not applicable for the modern one. 
(The modern skin doesn't inherit the system colors at all.)

Comment 3

[Blake Ross]

themes

Comment 4

[Matthew Mastracci]

Scroll bar is the same - it looks a little pale with my darker color scheme.  I
think it should be inheriting from the same colors as the control bar's button
backgrounds, etc.

Comment 5

[Rann Bar-On]

confirmed with 080101, win95

Comment 6

[hangas]

Ben, sending to you for comment.  Please forward to nbhatla if you feel this 
should be fixed by him.

Comment 7

[Paul Wyskoczka]

Updating QA Contact to [e-mail]

Comment 8

[Karl Ove Hufthammer]

I'm experiencing this problem too.

Comment 9

[Matthew Mastracci]

This bug is REALLY annoying for those of us with non-default background colors 
for windows.  :)  It is an easy fix, however.

Fix: replace the contents of chrome\classic\skin\classic\communicator\box.css 
with:



.box-toolbar-group
  {
    -moz-binding          : url
("chrome://global/skin/classicBindings.xml#double-box");
    border-left           : 1px solid threedshadow;
    border-top            : 1px solid threedshadow;
    border-bottom         : 1px solid threedhighlight;
    border-right          : 1px solid threedhighlight;
    background-color      : window;
    margin                : 0px;
  }
  
.box-toolbar-group > .db-internal-box
  {
    border                : 1px solid threeddarkshadow;
  }  

Comment 10

[Matthew Mastracci]

Attachment: New box.css attached, rather than inline

Comment 11

[Matthew Mastracci]

Can someone add the "patch" keyword to this bug?  It needs to get on someone's
radar so the fix can go in (it's a highly visible, low risk patch bug)

Comment 12

[Joe Hewitt (gone)]

Bug 57429 is for ensuring that all system colors are used properly in the
classic skin, so marking this bug as a duplicate.  Matthews patch will still be
taken into account for 57429.


*** This bug has been marked as a duplicate of 57429 ***

Comment 13

[Diego]

Verified dupe of bug 57429: "Win classic theme should support system colors"