46916 - :last-child pseudoclass

Status: VERIFIED FIXED

(Core :: CSS Parsing and Computation, enhancement, P3)

Description

[hand]

Please implement the CSS3 last-child pseudoclass selector.

Comment 1

[Pierre Saslawsky]

This bug is related to bug 46638. Marking Future/easy fix. Maybe it will make it 
before we ship. The reporter also wanted the 'subject' pseudo-class.

Comment 2

[Hixie (not reading bugmail)]

This would be a great one to implement if, as you say, it is easy, especially
considering the alleged feature set of our future competition...

Comment 3

[Daniel Glazman (:glazou) (not active in Mozilla any more)]

About the ":subject" thing : it has been dropped in the last version of the
draft. It has a huge performance side effect and its syntax was not clear. (just
as a reminder : I am the original proposer and implementor of this pseudo).

Comment 4

[Hixie (not reading bugmail)]

Netscape's standard compliance QA team reorganised itself once again, so taking 
remaining non-tables style bugs. Sorry about the spam. I tried to get this done 
directly at the database level, but apparently that is "not easy because of the 
shadow db", "plus it screws up the audit trail", so no can do...

Comment 5

[Boris Zbarsky [:bzbarsky]]

*** Bug 72219 has been marked as a duplicate of this bug. ***

Comment 6

[Hixie (not reading bugmail)]

Attachment: Patch: adds lastChildPseudo and related logic analogous to firstChild code

Comment 7

[Hixie (not reading bugmail)]

Attached patch adds code to mirror what we do with :first-child and :first-node,
but for :last-child and :last-node.

Pierre: Could I have r= and moa= please?
Attinasi: Could I have sr= please?

Thanks...

Comment 8

[Daniel Glazman (:glazou) (not active in Mozilla any more)]

Attachment: DHTML test case for :last-child pseudo-class

Comment 9

[Daniel Glazman (:glazou) (not active in Mozilla any more)]

Please run the test I attached above. You'll see that we have a problem with
elements not loosing pseudo-classes...

Comment 10

[Hixie (not reading bugmail)]

Yep. Seems like we're not recomputing enough of the style. That's another bug
though (would you like me to file it?).

Comment 11

[Pierre Saslawsky]

This patch is good, r=pierre.  Open a separate bug report with dependency on this 
one for the problem with DHTML.  Thanks to Daniel for the excellent testcase...

Comment 12

[Daniel Glazman (:glazou) (not active in Mozilla any more)]

Created 73586 with detected reflow bug 

Comment 13

[James Lariviere]

when are you checking this in?

Comment 14

[Hixie (not reading bugmail)]

As soon as I get a super review, why? I haven't been pushing for one, if you 
need this urgently then I can see about speeding up the process...

Comment 15

[James Lariviere]

Well to tell you the truth I could really use this for a website I help run...
www.mutualfundsnet.com.  I use the :first-child but it would be better to also
use the :last-child.

This would make my life easier with the boss... ;-)

thanks hixie

Comment 16

[Hixie (not reading bugmail)]

Marc sent me sr=attinasi by mail (thanks Marc). Any volunteers for checkin?

Comment 17

[James Lariviere]

[e-mail] checked it in this morning.

Comment 18

[Daniel Glazman (:glazou) (not active in Mozilla any more)]

Checked in for Ian

Comment 19

[James Lariviere]

I just checked my testcases with win 03-30-04 build and :last-child works great!

THanks Ian.

Comment 20

[Hixie (not reading bugmail)]

Daniel: Thanks for checking it in.
James: Thanks for verifying the fix.