469250 - Fix capitalization of Flashblock in Camino code/comments

Status: RESOLVED FIXED

(Camino Graveyard :: General, defect)

Description

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

Attachment: Fix "Flashblock" in code comments v0.9 (not for review)

Despite the ambiguous capitalization on flashblock.mozdev.org, the project is "Flashblock" (as established by comments in some bug and mozilla/camino/flashblock/README.

I have a patch that fixes this in code comments (and makes a few other grammar/punctuation changes to those comments I'm touching).

I'll attach it here for backup purposes, but it's not for review (or use) until the Flashblock whitelist and Chris's WebFeatures whitespace changes have landed.

Comment 1

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

cl suggested we really should fix all the code as well; hendy's got a patch nearly ready for the context menu stuff, so this should wait until after that now.

Comment 2

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

Attachment: Fix "Flashblock" in code and comments

This patch brought to you by the miracles of mxr+find-and-replace.  I also fixed a couple of the Flashblock-related comments to have correct punctuation and/or grammar and/or line length.

This requires a nib change to get the updated whatever-they-are references into the .nib; I've tested and things seem to work fine, but I'm attaching it below and requesting a further sanity-check from someone who understands nib-code relationships ;)

Comment 3

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

Attachment: Updated WebFeatures.nib

Saved in IB 2.5.6, because I can.

Comment 4

[Stuart Morgan]

Comment on attachment 385607 [details] [diff] [review]
Fix "Flashblock" in code and comments

Looks like you search-and-replaced FlashBlock, but not flashBlock.

>-  BOOL flashBlockAllowed = [self isFlashBlockAllowed];
>+  BOOL flashBlockAllowed = [self isFlashblockAllowed];
...
> - (void)flashBlockPrefChanged:(NSNotification*)inNotification
...
>   BOOL flashBlockEnabled = allowed && [self getBooleanPref:kGeckoPrefBlockFlash withSuccess:NULL];

Comment 5

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

Attachment: Fix "Flashblock" in code and comments, take 2

> Looks like you search-and-replaced FlashBlock, but not flashBlock.

This is why we don't have me writing code ;-) I hadn't even realized we had other forms of mis-capitalization errors!

This patch s/FlashBlock/Flashblock/, s/flashBlock(.*)/flashblock\1/, and s/flashblock/Flashblock/ (some comments in CHBrowserView.{h|mm} and all-camino.js.in), which should now cover everything outside of filenames and paths.

Comment 6

[Stuart Morgan]

Comment on attachment 385936 [details] [diff] [review]
Fix "Flashblock" in code and comments, take 2

Looks good, and the nib changes look sane. Thanks for taking care of this :)

sr=smorgan.

Comment 7

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

Landed on cvs trunk.