Wave: Seeks after playback ended but before playback ended event are lost

RESOLVED FIXED

Status

()

Core
Audio/Video
P2
normal
RESOLVED FIXED
10 years ago
9 years ago

People

(Reporter: kinetik, Assigned: kinetik)

Tracking

({fixed1.9.1})

Trunk
fixed1.9.1
Points:
---
Bug Flags:
blocking1.9.1 +

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

10 years ago
+++ This bug was initially created as a clone of Bug #469016 +++

Via code inspection, the Wave decoder appears to have the same bug.  Patch coming up.
Flags: blocking1.9.1?
Flags: blocking1.9.1? → blocking1.9.1+
What happened to that patch? :-)
Priority: -- → P2
(Assignee)

Comment 2

9 years ago
It turned out to be a fair bit tricker to fix than the Ogg decoder variant of the bug.  I've got a patch lying around that does the obvious fix, but it causes subtle breakage (that the tests show sometimes), so I'll have to come back to it soon.
(Assignee)

Comment 3

9 years ago
Created attachment 363832 [details] [diff] [review]
patch v0

Allow transition from ENDED->SEEKING if seek is requested before ended event is fired.  Track playback state in mPaused and use it to return to last playback state once seek completes.

Passes multiple runs of Chris Pearce's standalone testcase from bug 469016, and all mochitests (on OS X and Windows).

No mochitest because it's difficult-to-impossible to test for this reliably, Chris's testcase relies on multiple long runs to produce the fault.
Attachment #363832 - Flags: superreview?(roc)
Attachment #363832 - Flags: review?(roc)
Attachment #363832 - Flags: superreview?(roc)
Attachment #363832 - Flags: superreview+
Attachment #363832 - Flags: review?(roc)
Attachment #363832 - Flags: review+
Pushed http://hg.mozilla.org/mozilla-central/rev/47ee5c48a37a
Status: ASSIGNED → RESOLVED
Last Resolved: 9 years ago
Resolution: --- → FIXED
Whiteboard: [needs 191 landing]
You need to log in before you can comment on or make changes to this bug.