469275 - Wave: Seeks after playback ended but before playback ended event are lost

Status: RESOLVED FIXED

(Core :: Audio/Video, defect, P2)

Description

[Matthew Gregan [:kinetik]]

+++ This bug was initially created as a clone of Bug #469016 +++

Via code inspection, the Wave decoder appears to have the same bug.  Patch coming up.

Comment 1

[Robert O'Callahan (:roc) (email my personal email if necessary)]

What happened to that patch? :-)

Comment 2

[Matthew Gregan [:kinetik]]

It turned out to be a fair bit tricker to fix than the Ogg decoder variant of the bug.  I've got a patch lying around that does the obvious fix, but it causes subtle breakage (that the tests show sometimes), so I'll have to come back to it soon.

Comment 3

[Matthew Gregan [:kinetik]]

Attachment: patch v0

Allow transition from ENDED->SEEKING if seek is requested before ended event is fired.  Track playback state in mPaused and use it to return to last playback state once seek completes.

Passes multiple runs of Chris Pearce's standalone testcase from bug 469016, and all mochitests (on OS X and Windows).

No mochitest because it's difficult-to-impossible to test for this reliably, Chris's testcase relies on multiple long runs to produce the fault.

Comment 4

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Pushed http://hg.mozilla.org/mozilla-central/rev/47ee5c48a37a

Comment 5

[Robert O'Callahan (:roc) (email my personal email if necessary)]

http://hg.mozilla.org/releases/mozilla-1.9.1/rev/ad31ab5ad8e2