469346 - Plugin notification pref needs to get out of the Enable Plugins for MailNews groupbox

Status: RESOLVED FIXED

(SeaMonkey :: Preferences, defect)

Description

[Stefan [:stefanh]]

I think there are 2 reasons for not having the notification pref in the Advanced: Scripts & Plugins pane in the "Enable Plugins for" groupbox:

1) It's a bit confusing, because one might get the impression that they're connected.

2) By looking at the code, it seems that the notification pref checkbox won't be visible if you choose to not install MailNews.

Comment 1

[Stefan [:stefanh]]

I've been playing a bit with this and for me everything fits in to the panel even with a new groupbox (Classic and Modern on mac). Not sure about win/nix, though. Imo, a groupbox is the best solution since then the indentation will be the same (look at the Appearance panel and notice how the "Show tooltips" checkbox look together with the surrounding groupboxes).

Comment 2

[Stefan [:stefanh]]

Attachment: Put the checkbox in its own groupbox

I'd like Jens to comment on this, since it might be that he tested this and it didn't fit.

Comment 3

[Stefan [:stefanh]]

Attachment: Same as before, but fix a spelling error

mxr didn't found "mailPrefOverlay.xul" ;-)

Comment 4

[Jens Hatlak (:InvisibleSmiley)]

(In reply to comment #2)
> Created an attachment (id=352759) [details]
> Put the checkbox in its own groupbox
> 
> I'd like Jens to comment on this, since it might be that he tested this and it
> didn't fit.

I didn't and it fits. :-)

Comment 5

[Stefan [:stefanh]]

Comment on attachment 352760 [details] [diff] [review]
Same as before, but fix a spelling error

I added an id to the new groupbox, not really sure if it's necessary. A comment from Karsten in some bug I don't remember keeps echoing in my head, but that could just be me and the fact that is friday and I've been working all week and not had enough sleep.

Comment 6

[[e-mail]]

Comment on attachment 352760 [details] [diff] [review]
Same as before, but fix a spelling error

>+      <caption label="&whenPluginsRequired.description;"/>
You need to remove the trailing : from the entity, and also rename it to .label for consistency and so localisers notice ;-) sr=me with that fixed.

Comment 7

[Stefan [:stefanh]]

Pushed changeset d88275bc5d35 to comm-central (with comment #6 addressed).