If you think a bug might affect users in the 57 release, please set the correct tracking and status flags for Release Management.

Fix seizure-inducing flicker when inspector is hovered on element boundaries

VERIFIED FIXED

Status

Testing Graveyard
Mozmill
VERIFIED FIXED
9 years ago
a year ago

People

(Reporter: tracy, Assigned: whimboo)

Tracking

Details

Attachments

(1 attachment)

(Reporter)

Description

9 years ago
MozMill with the Inspector enable goes into wicked flickering when mousing over boundaries of various elements.  

STR:
1) Open the default Firefox start page.  anything will work actually even inside MozMill interface.

2) slowly move the mouse around until you're hovering over the edge of an element

Tested results:
The outline of the elements vying for attention flicker back and forth and the UI in MozMill UI of inspector and View pane allows dance in attempt to report the element data for both elements

Expected results:  no seizure inducing flickering in either app content outlining nor in the MozMill UI.

Comment 1

9 years ago
For the elements that would flicker, I am now not outlining them in blue and instead just displaying the locator.. everything else will be outlined as usual. If people could give this a try and let me know if it's better that would be helpful.
Is this fixed?

Comment 3

9 years ago
Haven't had any complains since I checked in this code, so I am assuming the solution did the trick.. go ahead and mark this fixed.
(Assignee)

Comment 4

9 years ago
It flickers heavily while hovering over the tab buttons beneath the inspector output, e.g. the Event button. Further the lines are moving some pixels while hovering over the output pane.

I believe that the output pane shouldn't be automatically resized. Can't we give it a fixed height and show scroll bars if needed?
(Assignee)

Comment 5

9 years ago
To avoid flickering on webpages we should use outline instead of border. Outline doesn't add extra pixels around the element. inspectElement in inspection.js should be changed to following code:

  //Element hilighting
  if (e.type == "mouseover"){
    try {
      if (this.lastEvent){
        this.lastEvent.target.style.outline = "";
      }
      this.lastEvent = e;
      e.target.style.outline = "1px solid darkblue";
    } catch(err){}
  }
  else { e.target.style.outline = ""; }
(Assignee)

Comment 6

9 years ago
Created attachment 355656 [details] [diff] [review]
[checked-in] Patch for border issue

This will fix the elements jumping issue on websites and for browser chrome.
Attachment #355656 - Flags: review?(mrogers)
Summary: Fix seizure inducing flicker when inspector is hovered on element boundaries → Fix seizure-inducing flicker when inspector is hovered on element boundaries

Comment 7

9 years ago
This worked like a charm, thanks so much Henrik, I had no idea the outline property even existed. Checked into trunk and tested.
(Assignee)

Comment 8

9 years ago
You are welcome! Adam, can you take the review request and close this bug as fixed? Or are there any other issues to resolve?

I should file a new bug for the inspector output flickering, right?
Assignee: nobody → hskupin
Status: NEW → ASSIGNED

Comment 9

9 years ago
I actually don't have access to close this, can someone look into that? I'm not sure I can take the review request without access either. Yes I would file another bug for output flickering. Thanks again.
Fixed :)
Status: ASSIGNED → RESOLVED
Last Resolved: 9 years ago
Resolution: --- → FIXED
(Assignee)

Updated

9 years ago
Attachment #355656 - Attachment description: Patch for border issue → [checked-in] Patch for border issue
Attachment #355656 - Flags: review?(mrogers)
(Assignee)

Comment 11

9 years ago
Comment on attachment 355656 [details] [diff] [review]
[checked-in] Patch for border issue

Seems like we don't need the request any longer.
(Assignee)

Comment 12

9 years ago
(In reply to comment #9)
> sure I can take the review request without access either. Yes I would file
> another bug for output flickering. Thanks again.

Filed as bug 472453.
(Assignee)

Comment 13

9 years ago
Works sweet! Verified.
Status: RESOLVED → VERIFIED
Product: Testing → Testing Graveyard
You need to log in before you can comment on or make changes to this bug.