remove native widgets from xul decks

RESOLVED FIXED

Status

()

Core
XUL
RESOLVED FIXED
9 years ago
9 years ago

People

(Reporter: blassey, Assigned: blassey)

Tracking

({fixed1.9.1, mobile})

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(3 attachments, 1 obsolete attachment)

Created attachment 352798 [details] [diff] [review]
"turn off" native widgets in deck implimentation 

Deck elements have been a significant performance problem for mobile, presumably because they create native widgets.
Attachment #352798 - Flags: review?(bzbarsky)
(Assignee)

Updated

9 years ago
Attachment #352798 - Flags: review?(roc)
Created attachment 352804 [details] [diff] [review]
test
Created attachment 352805 [details]
test results
I assume you tested things like iframes in decks?  And trees in decks?  Trees in decks are why that code is there in the first place (see bug 43206).

I'm not quite sure what the test attached here is testing, fwiw.
Some people use decks to work around bug 130078. Changing this would break them.
For that reason I think I'd prefer it if we turned off widgets based on checking some attribute of the <deck>, say <deck lightweight="true">.
(In reply to comment #5)
> For that reason I think I'd prefer it if we turned off widgets based on
> checking some attribute of the <deck>, say <deck lightweight="true">.

One thing that concerns me is an extension introducing a major performance problem by inadvertently.  If there was a flag, it might be better for it to be <deck forcenative="true"/>

Do you have an example of where someone is using this work around?

Comment 7

9 years ago
(In reply to comment #6)
> One thing that concerns me is an extension introducing a major performance
> problem by inadvertently.  If there was a flag, it might be better for it to be
> <deck forcenative="true"/>

That wouldn't be backwards compatible. If mobile wants all decks to not use widgets then maybe a preference or build-time option would be better. Essentially we don't want to have to have developers think about this kind of low-level thing, especially when we want to remove these widgets anyway.
(In reply to comment #6)
> (In reply to comment #5)
> > For that reason I think I'd prefer it if we turned off widgets based on
> > checking some attribute of the <deck>, say <deck lightweight="true">.
> 
> One thing that concerns me is an extension introducing a major performance
> problem by inadvertently.  If there was a flag, it might be better for it to be
> <deck forcenative="true"/>
> 
> Do you have an example of where someone is using this work around?

I don't have an example at hand, but I know that this work-around has been recommended to people in the past.

The safe thing to do here is to be backwards compatible. If we want to use a pref to switch this behaviour for mobile, that's OK with me. I could even accept an #ifdef, since I expect to be getting rid of these widgets anyway.
Created attachment 353580 [details] [diff] [review]
ifdef's based on  MOZ_GFX_OPTIMIZE_MOBILE
Assignee: nobody → bugmail
Attachment #352798 - Attachment is obsolete: true
Status: NEW → ASSIGNED
Attachment #353580 - Flags: review?(roc)
Attachment #352798 - Flags: review?(roc)
Attachment #352798 - Flags: review?(bzbarsky)
Attachment #353580 - Flags: superreview+
Attachment #353580 - Flags: review?(roc)
Attachment #353580 - Flags: review+
Perhaps MOZ_GFX_OPTIMIZE_MOBILE should be renamed to MOZ_OPTIMIZE_MOBILE if it's going to be used outside of gfx.
changeset:   23178:aed3c0bdeb72
tag:         qparent
user:        Brad Lassey <blassey@mozilla.com>
date:        Mon Dec 29 12:00:12 2008 -0500
summary:     bug 469412 -  remove native widgets from xul decks, mobile only r+sr=roc
(Assignee)

Updated

9 years ago
Status: ASSIGNED → RESOLVED
Last Resolved: 9 years ago
Resolution: --- → FIXED
pushed http://hg.mozilla.org/releases/mozilla-1.9.1/rev/45db3a2e209f
(Assignee)

Updated

9 years ago
Keywords: fixed1.9.1
You need to log in before you can comment on or make changes to this bug.