469465 - Drag'n'drop to create bookmark doesn't work

Status: RESOLVED FIXED

(SeaMonkey :: Bookmarks & History, defect)

Description

[[e-mail]]

Unlike most other ways of adding a bookmark, drag'n'drop tries to be clever and use the linked page's title from history rather than the link text. Of course the code needs to be updated to work with Places.

Comment 1

[[e-mail]]

Attachment: Proposed patch

Comment 3

[jag (Peter Annema)]

Comment on attachment 352839 [details] [diff] [review]
Proposed patch

Does it make sense to use the document's charset for URLs (and the bookmarks themselves, for that matter) that can be pasted or dropped from anywhere?

Comment 4

[[e-mail]]

Attachment: Revised patch

As discussed on IRC.

Comment 5

[jag (Peter Annema)]

Reading the code for |nsBookmarksService::CreateBookmark()| it expects the charset passed in (if any) to be the one from the last visit. I don't think |focusedWindow.document.characterSet| is always the right one.

How about something like:

    if (!aName || !aCharSet) {
      try {
        let navHistory = Components.classes["@mozilla.org/browser/nav-history-service;1"]
                                   .getService(Components.interfaces.nsINavHistoryService);
        let uri = makeURI(aURL, aCharSet);
         // look the name and/or charset up in history
        if (!aName)
          aName = navHistory.getPageTitle(uri);
        if (!aCharSet)
          aCharSet = navHistory.getCharsetForURI(uri);
      } catch (e) {}
    }
    if (!aName)
      aName = aDefaultName || aURL;

Comment 6

[[e-mail]]

Attachment: Third time lucky?

Comment 7

[jag (Peter Annema)]

Comment on attachment 352898 [details] [diff] [review]
Third time lucky?

r/sr=jag

Comment 8

[[e-mail]]

Pushed changeset 8c03ecb42b18 to comm-central.