Closed Bug 469569 Opened 16 years ago Closed 16 years ago

Drop pointlessly copying mailViews.dat to en-US/

Categories

(MailNews Core :: Build Config, defect)

defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED
Thunderbird 3.0b2

People

(Reporter: philor, Assigned: philor)

Details

Attachments

(1 file)

Attached patch Fix v.1Splinter Review
Somewhere back in the bowels of the confusing stew of profile switching and content packs and region packs and language packs, it apparently made sense to put mailviews.dat into both defaults/messenger/mailviews.dat and defaults/messenger/US/mailviews.dat (en-US, following bug 325473).

That time has passed.

The only thing actually packaging it is SM/Linux - for SM/Windows and Tb, it's just noise in compare-packages, and try as I might, I can't find anything in the tree which would have the slightest interest in using it if it was packaged.
Attachment #352928 - Flags: superreview?(bugzilla)
Attachment #352928 - Flags: review?(kairo)
Attachment #352928 - Flags: review?(kairo) → review+
Comment on attachment 352928 [details] [diff] [review]
Fix v.1

It made sense back when we could have multiple region packs install different default files for profiles and the new profile dialog did let you chose the region to create the profile for (which would use the subdir) and we'd use the non-subdir'd one by default.
The toolkit profile system doesn't support this, and the concept doesn't work well with langpacks being full extensions, so this is good cleanup.

r=me from code inspection (didn't actually test it, but I trust it works fine).
Attachment #352928 - Flags: superreview?(bugzilla) → superreview+
http://hg.mozilla.org/comm-central/rev/33b262c9560f
Status: ASSIGNED → RESOLVED
Closed: 16 years ago
Resolution: --- → FIXED
Summary: Drop pointlessly copying mailview.dat to en-US/ → Drop pointlessly copying mailViews.dat to en-US/
Target Milestone: --- → Thunderbird 3.0b2
You need to log in before you can comment on or make changes to this bug.