469579 - Coverity: uninitialized variable used in pkix_ComCRLSelParams_Duplicate and pkix_CRLSelector_Duplicate

Status: RESOLVED FIXED

(NSS :: Libraries, defect, P2)

Description

[Nelson Bolyard (seldom reads bugmail)]

According to Coverity, run 278, CID 1394, 
in file nss/lib/libpkix/pkix/crlsel/pkix_comcrlselparams.c, function 
pkix_ComCRLSelParams_Duplicate, it is possible to reach label cleanup:
and PKIX_DECREF(new), when new is uninitialized, unassigned. 
Should just initialize it to NULL.

Comment 1

[Nelson Bolyard (seldom reads bugmail)]

Rather than filing a separate bug for every Coverity issue in libPKIX, 
I will add some others to this bug.

According to Coverity, run 278, CID 1394, 
in file nss/lib/libpkix/pkix/crlsel/pkix_crlselector.c, 
function pkix_CRLSelector_Duplicate, it is possible to reach label cleanup:
and PKIX_DECREF(new), when new is uninitialized, unassigned. 
Should just initialize it to NULL.

Comment 2

[timeless]

Attachment: initialize

Comment 3

[Nelson Bolyard (seldom reads bugmail)]

Comment on attachment 430927 [details] [diff] [review]
initialize

r=nelson

Comment 4

[Nelson Bolyard (seldom reads bugmail)]

pkix/crlsel/pkix_comcrlselparams.c; new revision: 1.8; previous revision: 1.7
pkix/crlsel/pkix_crlselector.c;     new revision: 1.11; previous revision: 1.10

Thanks, Timeless