46961 - Buttons shouldn't visually respond if disabled

Status: RESOLVED FIXED

(SeaMonkey :: Themes, defect, P2)

Description

[Blake Ross]

Build ID: 2000072908

Disabled XUL buttons still seem to depress, even if they're disabled.  You can 
see this with the remove buttons in the image/cookie manager, if you have no 
blocked sites or cookies.  

These lines in button.css are calling the problem:

  button:hover:active 
    {
      border              : 1px solid threeddarkshadow;
    }

  button:hover:active > .button-box-1
    {
      border              : 1px solid threedshadow;
    }

  button:hover:active > .button-box-1 > .button-box-2
    {
      border              : 1px solid threedface;
    }

So, obviously, the solution is to add a border style to this rule:

  button[disabled="true"],
  button[disabled="true"]:hover:active
    {
      color               : graytext;
    }

However, I can't figure out which border to set.  I tried various ones, 
including 0px, and though they had different effects, none had *no* effect 
(which is what's needed here).  So, basically I can't figure out what border a 
normal disabled button has (because that's the border we need to set for button
[disabled="true"]:hover:active, so nothing seems to happen on click)

Comment 1

[Blake Ross]

Will probably get fixed by hyatt's checkin to fix bug 30644...

Comment 2

[Blake Ross]

*** Bug 48606 has been marked as a duplicate of this bug. ***

Comment 3

[Blake Ross]

*** Bug 51493 has been marked as a duplicate of this bug. ***

Comment 4

[Phil Peterson]

nominate nsbeta3 and rtm per PDT review of Classic theme

Comment 5

[verah (gone)]

Nav triage team: [nsbeta3+], since PDT hath spoken.

Comment 6

[Peter Trudelle]

PDT thinks this is P4

Comment 7

[don]

Marking as "nsbeta3-".

Comment 8

[don]

Ben, do you have a fix for this yet?  Or should we minus this.

Comment 9

[verah (gone)]

Nav triage team: No fix for this yet; must minus.

Comment 10

[Blake Ross]

Let's do this for 6.01, since Ben said he had a fix for this awhile ago.

Comment 11

[Henrik Gemal]

Any chance we'll see a fix for this soon?
It's a bit confusing for new users that they seem to be able to press disabled 
buttons...

Comment 12

[Joe Hewitt (gone)]

taking

Comment 13

[hangas]

Themes Triage Team nsbeta1+

Comment 14

[Joe Hewitt (gone)]

Attachment: patch to fix (don't apply this patch, it's been trimmed)

Comment 15

[Blake Ross]

Applied it by hand, this looks great to me. r=blake

Comment 16

[hangas]

a=hangas

Comment 17

[Joe Hewitt (gone)]

fixed