Closed Bug 469630 Opened 11 years ago Closed 11 years ago

Thunderbird just gets confused by nsComposerCmdLineHandler.js

Categories

(Core :: DOM: Editor, defect)

defect
Not set

Tracking

()

RESOLVED FIXED

People

(Reporter: philor, Assigned: philor)

References

Details

Attachments

(1 file)

Attached patch Fix v.1Splinter Review
Since Thunderbird doesn't have a clue how to actually deal with an "-edit" commandline flag (unless you consider opening a window with an XML parsing error dealing with), we don't package nsComposerCmdLineHandler.js on Windows (or on Linux, once we have a package manifest for it), which leaves us having to remember that it's okay to see it listed in package-compare output, and having it shipped on OS X unless we develop enough sense to add it to NO_PKG_FILES. Instead of that, since editor/ui/ already has MOZ_SUITE ifdefs, not even having it end up in dist/bin/ for anyone but SeaMonkey seems more reasonable.
Attachment #352980 - Flags: superreview?(neil)
Attachment #352980 - Flags: review?(neil)
Blocks: 453110
Comment on attachment 352980 [details] [diff] [review]
Fix v.1

Hmm, I wonder how many of those composer.js prefs you use ;-)
Attachment #352980 - Flags: superreview?(neil)
Attachment #352980 - Flags: superreview+
Attachment #352980 - Flags: review?(neil)
Attachment #352980 - Flags: review+
http://hg.mozilla.org/comm-central/rev/8c78770a1e48

I considered the prefs question, and then I thought about filing it and claiming it was a [good first bug], but since I already unset the only bothersome one, the throbber URL, it doesn't seem worth digging through all the callsites to really find out. Yet.
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.