If you think a bug might affect users in the 57 release, please set the correct tracking and status flags for Release Management.

Status

()

Core
Embedding: APIs
RESOLVED FIXED
9 years ago
9 years ago

People

(Reporter: Tobias Hunger, Unassigned)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Reporter)

Description

9 years ago
User-Agent:       Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9.0.4) Gecko/2008111616 Ubuntu/9.04 (jaunty) Firefox/3.0.4
Build Identifier: hg rev. 0c3baa33bba5

The attached patch includes cleanups only. It does not change the behavior of the code.

* Adds copyright header to embed.h.
* Changes copyright year from 20007 to 2007 in embed.cpp.
* Renames parameters to start with a.
* Renames member variables to start with m.
* Fixes indention to 4 spaces.
* Renames header guard to not start with _. Such names are reserved!
* Small fixes to the doxygen comments.

This patch should be straight forward to review:-)

Reproducible: Always
(Reporter)

Comment 1

9 years ago
Created attachment 353008 [details] [diff] [review]
embed.(h|cpp) cleanup patch.
(Reporter)

Updated

9 years ago
Blocks: 467074
(Reporter)

Updated

9 years ago
Blocks: 469661
(Reporter)

Updated

9 years ago
Blocks: 469663
(Reporter)

Updated

9 years ago
Blocks: 469665
(Reporter)

Updated

9 years ago
Attachment #353008 - Flags: review?(mark.finkle)
http://hg.mozilla.org/incubator/embedding/rev/43a4f0d6d89e
Status: UNCONFIRMED → RESOLVED
Last Resolved: 9 years ago
Resolution: --- → FIXED
Attachment #353008 - Flags: review?(mark.finkle) → review+
You need to log in before you can comment on or make changes to this bug.