Closed
Bug 469655
Opened 16 years ago
Closed 16 years ago
Drop intermediate Makefiles in mail/themes
Categories
(Thunderbird :: Build Config, defect)
Thunderbird
Build Config
Tracking
(Not tracked)
RESOLVED
FIXED
Thunderbird 3.0b2
People
(Reporter: standard8, Assigned: standard8)
References
Details
Attachments
(1 file)
105.27 KB,
patch
|
philor
:
review+
|
Details | Diff | Splinter Review |
When we make our themes, we go into: mail/themes mail/themes/<theme-name> mail/themes/<theme-name>/mail mail/themes/<theme-name>/editor That's four directories we're entering, and only two of them are doing anything. Not only that, the two that do anything result in the same output file. Therefore we should just move the jar.mn to mail/themes/<theme-name> and jump straight to there from mail/, hence dropping entering three of those directories and saving the need to open/close a file twice.
Attachment #353012 -
Flags: review?(philringnalda)
Comment 1•16 years ago
|
||
Comment on attachment 353012 [details] [diff] [review] The fix Sweet! >+ifneq (,$(filter mac cocoa,$(MOZ_WIDGET_TOOLKIT))) ifeq (cocoa,$(MOZ_WIDGET_TOOLKIT)), por favor. I've seen people just drop the "mac", but that still requires more thought about "filter is keep, it's filter-out that's remove" than just an ifeq, and if someone does yet another OS X widget toolkit, they deserve to suffer.
Attachment #353012 -
Flags: review?(philringnalda) → review+
Comment 2•16 years ago
|
||
(Where by r+, I meant "r+ with the (mail/communicator.css) that qute needs to actually build.")
Assignee | ||
Comment 3•16 years ago
|
||
Checked in: http://hg.mozilla.org/comm-central/rev/403e3d628d5b Checked in: http://hg.mozilla.org/comm-central/rev/3c0ebc33dcfb (this one because I forgot to save addressing the first review comment before committing).
Status: NEW → RESOLVED
Closed: 16 years ago
Flags: in-testsuite-
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•