NS_ERROR_FAILURE exception thrown instead of NO_MODIFICATION_ALLOWED_ERR

VERIFIED FIXED in Future

Status

()

Core
DOM: Core & HTML
P3
major
VERIFIED FIXED
18 years ago
10 years ago

People

(Reporter: ckritzer (gone), Assigned: jst)

Tracking

({dom1, polish})

Trunk
Future
dom1, polish
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [nsbeta1-], URL)

Attachments

(1 attachment)

(Reporter)

Description

18 years ago
Overview:  When catching the DOMException for node.replaceChild(), 

node.removeChild(), and node.appendChild(), the exception thrown is 

NS_ERROR_FAILURE instead of NO_MODIFICATION_ALLOWED_ERR.



Steps to Reproduce:

1) Launch 2000-07-25-xx build

2) Load:

	- http://voodoolady/dom1/cdex024.html [node.replaceChild()]

	- http://voodoolady/dom1/cdex025.html [node.removeChild()]

	- http://voodoolady/dom1/cdex026.html [node.appendChild()]



Actual Results: NS_ERROR_FAILURE exception thrown



Expected Results: NO_MODIFICATION_ALLOWED_ERR



Platforms Tested:

 - MacOS9 2000-07-25-11-M17

 - Linux6 2000-07-25-08-M17

 - Win98  2000-07-25-09-M17

Updated

18 years ago
QA Contact: gerardok → ckritzer
(Assignee)

Comment 1

18 years ago
Accepting and nominating for nsbeta3. Fixing this is trivial, it's just a matter
of changing NS_ERROR_FAILURE with the right DOM exception code in
nsDOMAttribute.cpp. 
Status: NEW → ASSIGNED
Keywords: correctness, nsbeta3, polish

Comment 2

18 years ago
Marking nsbeta3+...
Whiteboard: [nsbeta3+]

Updated

18 years ago
Whiteboard: [nsbeta3+] → [nsbeta3+] trivial fix
(Assignee)

Comment 3

18 years ago
This is now fixed.
Status: ASSIGNED → RESOLVED
Last Resolved: 18 years ago
Resolution: --- → FIXED
(Reporter)

Comment 4

18 years ago
Marking VERIFIED FIXED on:
- LinuxRH62 2000-09-07-08-M18 Commercial
- Win98     2000-09-07-08-M18 Mozilla
- MacOS86   2000-09-07-04-M18 Commercial
Status: RESOLVED → VERIFIED

Comment 5

18 years ago
fails on 

2000-10-12-09-Mtrunk : win32 
2000-10-12-13-MN6 : win32 

2000-10-12-09-MN6 : linux
 
2000-10-11-10-MN6 : mac 
2000-10-12-15-Mtrunk: mac
 
Status: VERIFIED → REOPENED
Resolution: FIXED → ---
(Assignee)

Comment 6

18 years ago
--> Future
Target Milestone: --- → Future

Comment 7

18 years ago
This bug was marked to be fixed in a previous milestone but it didn't get fixed 
properly. Nominated for beta1.
Keywords: nsbeta1
(Assignee)

Comment 8

18 years ago
This is not critical enough for nsbeta1.
Whiteboard: [nsbeta3+] trivial fix → [nsbeta1-]

Comment 9

18 years ago
changing qa contact
QA Contact: ckritzer → janc
Keywords: dom1
Component: DOM Level 1 → DOM HTML

Comment 10

18 years ago
QA contact Update
QA Contact: janc → desale
Keywords: nsbeta1 → nsbeta1-

Comment 11

18 years ago
Created attachment 31588 [details]
Testcase for bug 46966.

Comment 12

18 years ago
Worksforme build from 19/4. See attached testcase.
(Assignee)

Comment 13

18 years ago
Thank you Fabian!
Status: REOPENED → RESOLVED
Last Resolved: 18 years ago18 years ago
Resolution: --- → WORKSFORME

Comment 14

17 years ago
Updating QA contact to Shivakiran Tummala.
QA Contact: desale → stummala

Comment 15

17 years ago
fails on windows 07-18-05
Status: RESOLVED → REOPENED
Resolution: WORKSFORME → ---
wfm Windows 98, Mozilla build 2001111503

Comment 17

17 years ago
My testcase worksforme as well on linux cvs build from today. Marking FIXED
again. Sivakiran if you're still seeing this feel free to reopen, thanks.
Status: REOPENED → RESOLVED
Last Resolved: 18 years ago17 years ago
Resolution: --- → FIXED

Comment 18

17 years ago
marking verified
Status: RESOLVED → VERIFIED

Updated

10 years ago
Component: DOM: HTML → DOM: Core & HTML
QA Contact: stummala → general
You need to log in before you can comment on or make changes to this bug.