Closed
Bug 469683
Opened 16 years ago
Closed 16 years ago
Wrong context menu transparency
Categories
(Core :: Widget: Cocoa, defect)
Tracking
()
RESOLVED
FIXED
mozilla1.9.2a1
People
(Reporter: mstange, Assigned: mstange)
References
()
Details
(Keywords: fixed1.9.1, regression)
Attachments
(1 file)
|
3.37 KB,
patch
|
jaas
:
review+
roc
:
superreview+
beltzner
:
approval1.9.1+
|
Details | Diff | Splinter Review |
Since bug 391984 popup menu transparency is no longer implemented using -[NSWindow setAlphaValue:]; instead, we now make the window translucent and let -moz-appearance: menupopup / menuitem manage the transparency.
However, since the menuitems draw on top of the menupopup, their opacity gets multiplied. That means that the popup is now more transparent under the top and bottom padding than under the menuitems.
This patch adds a CGContextClearRect when drawing menuitems, as suggested in bug 391984 comment 5. This avoids the multiplying opacity problem.
Furthermore, I'm removing the popup window alpha stuff because we don't need it any more.
Attachment #353052 -
Flags: superreview?(roc)
Attachment #353052 -
Flags: review?(joshmoz)
Attachment #353052 -
Flags: review?(joshmoz) → review+
Attachment #353052 -
Flags: superreview?(roc) → superreview+
|
Assignee | |
Comment 1•16 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 16 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla1.9.2a1
|
|
Assignee | |
Updated•16 years ago
|
Attachment #353052 -
Flags: approval1.9.1?
|
||
Comment 2•16 years ago
|
||
Comment on attachment 353052 [details] [diff] [review]
patch v1
a191=beltzner
Attachment #353052 -
Flags: approval1.9.1? → approval1.9.1+
|
|
Assignee | |
Comment 3•16 years ago
|
||
Landed on 1.9.1:
http://hg.mozilla.org/releases/mozilla-1.9.1/rev/185e694dc180
Keywords: fixed1.9.1
You need to log in
before you can comment on or make changes to this bug.
Description
•