Closed
Bug 469690
Opened 17 years ago
Closed 14 years ago
TM: hoist typechecking guards
Categories
(Core :: JavaScript Engine, defect)
Core
JavaScript Engine
Tracking
()
RESOLVED
WONTFIX
People
(Reporter: robarnold, Assigned: robarnold)
References
Details
Attachments
(2 files, 1 obsolete file)
|
36.52 KB,
patch
|
Details | Diff | Splinter Review | |
|
11.93 KB,
patch
|
Details | Diff | Splinter Review |
Hoisting guards requires that we know a JSObject's classword will not change. This patch adds metadata to each call that indicates if that call can change the classword of any of its args.
|
||
Comment 1•17 years ago
|
||
Comment on attachment 353057 [details] [diff] [review]
clsword prop
Are you sure push/pop can't change the classword?
|
Assignee | |
Comment 2•17 years ago
|
||
Push can definitely make a dense array into a slow one. Pop cannot (though static verification would be nice). Slow arrays never become dense ones.
Attachment #353057 -
Attachment is obsolete: true
Attachment #353167 -
Flags: review?(gal)
|
|
Assignee | |
Comment 3•17 years ago
|
||
This patch looks for loads w/o corresponding stores and also hoists guards when possible.
Attachment #353168 -
Flags: review?(gal)
|
|
Assignee | |
Updated•16 years ago
|
Attachment #353167 -
Flags: review?(gal)
|
|
Assignee | |
Updated•16 years ago
|
Attachment #353168 -
Flags: review?(gal)
|
||
Comment 4•14 years ago
|
||
Obsolete with the removal of tracejit.
Status: NEW → RESOLVED
Closed: 14 years ago
Resolution: --- → WONTFIX
You need to log in
before you can comment on or make changes to this bug.
Description
•