Closed Bug 469720 Opened 16 years ago Closed 16 years ago

tabindex of -1 set in javascript ignored on file input

Categories

(Firefox :: Keyboard Navigation, defect)

Product:
Firefox
Component:
Keyboard Navigation
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED

People

(Reporter: bugs, Assigned: smaug)

References

(
URL
)

Details

Attachments

(2 files, 1 obsolete file)

bug testcase
870 bytes, application/xhtml+xml
Details
proposed patch
6.67 KB, patch
bzbarsky
: review+
bzbarsky
: superreview+
Details | Diff | Splinter Review 
The testcase attempts to set -1 on various form elements, spawned from the slightly more complex (and not totally IE compatible) test of "dialog" here:
http://m8y.org/js/test16.xhtml

Tested in IE6, Safari and Opera, all of whom correctly skip all the elements with tabindex="-1"
Attached file bug testcase — 

    
    

    
  
What is the actual bug here? Steps to reproduce?

    
    

    
  

      
      
      
      

        Attached patch
          
          
        WIP (obsolete)
        — 
          — Splinter Review
      

    


  
Not properly tested yet.
Assignee: nobody → Olli.Pettay
Status: NEW → ASSIGNED

    
    

    
  
Re: comment #2 - Steps to reproduce are detailed in the attached testcase.  The actual bug is specified in the bug title.  Setting tabindex="-1" (which means the element should get skipped over in tabbing) is ignored on file inputs if set in JS.

'course, there's apparently a fix already so my elaborating is probably pointless. :)

    
    

    
  

      
      
      
      

        Attached patch
          
          
        proposed patch
        — 
          — Splinter Review
      

    


  

        Attachment #353098 -
        Attachment is obsolete: true

        Attachment #353222 -
        Flags: superreview?(bzbarsky)

        Attachment #353222 -
        Flags: review?(bzbarsky)

    
    

    
  
I reused/extended the test for bug 238987.

    
    

    
  
And I don't want to hack accesskey handling in this bug. I'll file a
new bug if I find some problems with that attribute.

        Attachment #353222 -
        Flags: superreview?(bzbarsky)

        Attachment #353222 -
        Flags: superreview+

        Attachment #353222 -
        Flags: review?(bzbarsky)

        Attachment #353222 -
        Flags: review+
Status: ASSIGNED → RESOLVED
Closed: 16 years ago
Resolution: --- → FIXED

          You need to log in
          before you can comment on or make changes to this bug.
        






  

    
  







  

    

      
Attachment

      

      
      
      
      
    

    

      

        

          

            
General

            

              Creator: 



            

            
Created: 

            
Updated: 

            
Size: