469793 - [MySQL] In MySQL 5, columns sometimes have defaults that have no defaults in the Schema

Status: RESOLVED FIXED

(Bugzilla :: Database, defect)

Description

[Max Kanat-Alexander]

The current checksetup-landfill test is failing with a lot of differences like this:

-  `grantor_id` mediumint(9) NOT NULL default '0'
+  `grantor_id` mediumint(9) NOT NULL

When you import an old DB into MySQL 5, some columns contain defaults when they shouldn't--I think this is because old MySQLs always had defaults on columns. We should remove defaults from columns that aren't supposed to have them, on an upgrade.

Comment 1

[Max Kanat-Alexander]

Attachment: v1

Okay, this fixes it. We remove defaults from columns that shouldn't have them, if we're on MySQL 5 and bugs.assigned_to has a default (which is the oldest column that could have this problem).

Comment 2

[Max Kanat-Alexander]

Okay, tests should pass now.

Checking in Bugzilla/DB/Mysql.pm;
/cvsroot/mozilla/webtools/bugzilla/Bugzilla/DB/Mysql.pm,v  <--  Mysql.pm
new revision: 1.70; previous revision: 1.69
done