Closed Bug 469799 Opened 16 years ago Closed 15 years ago

De-COM nsSmtpServer::getIntPrefWithDefault

Categories

(MailNews Core :: Networking: SMTP, defect)

defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED
Thunderbird 3.0b2

People

(Reporter: standard8, Assigned: standard8)

Details

(Keywords: memory-footprint)

Attachments

(1 file, 2 obsolete files)

Attached patch The fix (obsolete) — Splinter Review
nsSmtpServer::getIntPrefWithDefault is a private function and always returns NS_OK. We can simplify this by just returning the result rather than passing the result as an argument.

Patch also includes a couple of nsresult cleanups. I was going to submit this as part of the password manager work, but the bit I was going to submit it alongside is no longer necessary.
Attachment #353196 - Flags: superreview?(neil)
Attachment #353196 - Flags: review?(neil)
Comment on attachment 353196 [details] [diff] [review]
The fix

IMHO trying to return the pref value is over-complicating.
Attachment #353196 - Flags: superreview?(neil)
Attachment #353196 - Flags: superreview-
Attachment #353196 - Flags: review?(neil)
Attached patch The fix v2 (obsolete) — Splinter Review
Revised to have a void return value to avoid going back and forth between pointer and non-pointer values.
Attachment #353196 - Attachment is obsolete: true
Attachment #353198 - Flags: superreview?(neil)
Attachment #353198 - Flags: review?(neil)
Attached patch The fix v2aSplinter Review
Opps, forgot to qrefresh before attaching.
Attachment #353198 - Attachment is obsolete: true
Attachment #353199 - Flags: superreview?(neil)
Attachment #353199 - Flags: review?(neil)
Attachment #353198 - Flags: superreview?(neil)
Attachment #353198 - Flags: review?(neil)
Attachment #353199 - Flags: superreview?(neil)
Attachment #353199 - Flags: superreview+
Attachment #353199 - Flags: review?(neil)
Attachment #353199 - Flags: review+
Patch checked in: http://hg.mozilla.org/comm-central/rev/588de2709665
Status: NEW → RESOLVED
Closed: 15 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla1.9.1b3
Product: Core → MailNews Core
Target Milestone: mozilla1.9.1b3 → Thunderbird 3.0b2
You need to log in before you can comment on or make changes to this bug.