469822 - Google analytics contributed module

Status: RESOLVED FIXED

(Mozilla Messaging Graveyard :: Server Operations, defect)

Description

[Paul Booker]

Hi Gozer ,

Can we get the Google analytics contributed module on stage for
final testing.


http://drupal.org/project/google_analytics 

Best, Paul

Comment 1

[Philippe M. Chiasson (:gozer)]

Done. Installed in staging and configured with our google analytics settings.

Comment 2

[Paul Booker]

@Gozer

Would you let me know when the status of the stage domain is confirmed by google as receiving data.

I'll then confirm that the google analytics contributed drupal module can add the google analytic javascript correctly.

 
Thanks, Paul

Comment 3

[Philippe M. Chiasson (:gozer)]

I created a new site in gogole analytics for stage.spreadthunderbird.com and updated the tracking code accordingly.

So far, I've had no luck locating the tracking code anywhere on the site.

Comment 4

[Philippe M. Chiasson (:gozer)]

From the settings here: http://stage.spreadthunderbird.com/admin/settings/googleanalytics

I can get the analytics code to show up if I pick Header placement under advanced settings, not if I pick Footer, the recommended default.

On top of that, the tracker invocation itself is always placed at the footer (looking at the google analytics drupal module code) and that will not show up either.

Is there something we are doing with our custom theme that might break 
things like:

drupal_add_js($script, 'inline', 'footer');

Comment 5

[Paul Booker]

Thanks for some great feedback. 

The problems is definitely not generic as i didn't come across these problems with garland (drupal default theme)

I'll look into this problem on my local server / vps server ...

-Paul

Comment 6

[Paul Booker]

The problem is not something specific to the acquia marina theme . I'll investigate our derivative stb theme in the morning.

Comment 7

[Paul Booker]

Sorry, the problem is specific to the acquia theme .

I have attached a screen shot of a vanilla installation of drupal with the acquia theme and and few block configured on the right hand side , you'll see a lot of empty space as before.

Comment 8

[Paul Booker]

Sorry Sorry , forget 7 

In 7 i am actually talking about the problem with our theme generating lots of space and that it is attributed to the theme and not something that is connected with our theme derivative

Ill look at 6 tomorrow , hope that's clear

Comment 9

[Paul Booker]

Hello,

The problem can resolved quickly with the patch given below but we will reintroduce the footer ..

"Theme provided by Acquia, Inc. under GPL license from TopNotchThemes Drupal themes"

.. which i think is a good thing on reflection as we should give clear recognition to TopNotchThemes who developed the base theme

bash-3.1$ svn diff
Index: page.tpl.php
===================================================================
--- page.tpl.php        (revision 20965)
+++ page.tpl.php        (working copy)
@@ -205,6 +205,6 @@
         </div><!-- /main-wrapper -->
       </div><!-- /main -->
     </div><!-- /page -->
-    <?php print $stb_closure; ?>
+    <?php print $closure; ?>
   </body>
 </html>
Index: template.php
===================================================================
--- template.php        (revision 20965)
+++ template.php        (working copy)
@@ -1,8 +1,4 @@
 <?php
-function stb_preprocess_page(&$vars) {
-   $vars['stb_closure'] .= '<div id="legal-notice"></div>';
-}
-
  
 /**
  * Intercept template variables


@Gozer 

Would you give me clearance please to commit the changes into SVN for final testing on stage

Thanks Paul

Comment 10

[Philippe M. Chiasson (:gozer)]

You don't need clearance to commit things in SVN, as staging is in effect your playground. Check it in, and let me know so I can update staging.

Comment 11

[Philippe M. Chiasson (:gozer)]

I've locally applied that change just to check how it worked, and it does fix the google analytics problems. However, it introduces a new problem.


"Theme provided by Acquia, Inc. under GPL license from TopNotchThemes Drupal themes"

Now appears twice

Comment 12

[Paul Booker]

Not sure what the problem is at the moment. 

I don't see this problem on my VPS server where i have the STB theme hosted and from where the above patch was generated. I tried clearing the caches on the STB stage server but that didn't rectify the problem so it looks to be a real problem somewhere.

Would you try the following on stage from the themes directory ..

grep -r "under GPL license from TopNotchThemes" acquia_marina

Actually you could try taking out the page template file page.tpl.php as this is now exactly the same as the acquia page template file

I'll come back to this problem later today

Best, Paul

Comment 13

[Philippe M. Chiasson (:gozer)]

Looks like the reason this is hapenning is because, somehow phptemplate_preprocess_page() in acquia_marina/template.php is invoked twice, with
this bit of code running twice:

 $vars['closure'] .= '<div id="legal-notice">Theme provided by [...]

Comment 14

[Paul Booker]

Looks have been resolved.

Comment 15

[Paul Booker]

Sorry, ignore the previous comment.

Comment 16

[Paul Booker]

Committed r21289

Comment 17

[Philippe M. Chiasson (:gozer)]

Upgraded stating, still showing twice...

Comment 18

[Paul Booker]

Would you try clearing the drupal cache tables directly . The problem with the footer is resolved on my local server but i think i did clear all the tables manually.

Comment 19

[Philippe M. Chiasson (:gozer)]

I'd need more detailled instructions on how to clear these.

But I don't think that's going to make it work, as I've fiddled with that template page, and I can make simple changes to it and see my changes reflected right away. Twice, when touching the footer.

Comment 20

[Paul Booker]

@ Gozer

Would you try truncating all the tables of the form cache_* please . If that doesn't work ill look at the problem again in the morning.

Comment 21

[Paul Booker]

The stb theme is definitely working fine as i can download it onto my local server and also onto my vps server on the internet where in both cases i have a server setup running drupal 6 with our list of contributed modules and acquia theme . On my local server i have also a fairly recent snap shop of the live database.

I think there must be a problem with one or several of the following.

1. drupal cache
2. proxy cache
3. stb directory in svn

I'll attach my HTTP headers for stage.spreadthunderbird.com ..

Comment 22

[Paul Booker]

Attachment: HTTP headers for stage.spreadthunderbird.com

Comment 23

[Philippe M. Chiasson (:gozer)]

Looks like it was induced by cacherouter (http://drupal.org/project/cacherouter).

I've disabled it's advanced options and the problem went away, so I've made the same change in production.

Comment 24

[Paul Booker]

Thanks for working this problem out.

Would you mind adding any other additional modules that you have added to stage/production to our wiki page @ https://wiki.mozilla.org/Spreadthunderbird

Thanks Paul

Comment 25

[Philippe M. Chiasson (:gozer)]

Updated wiki documentation.