469855 - Query portion of in-browser JS tests can't be rearranged

Status: RESOLVED FIXED

(Core :: JavaScript Engine, enhancement)

Description

[Jeff Walden [:Waldo]]

It would be nice to be able to put the test= portion at the end, to make it easier to tweak the URL to run a different test.  For example,

http://test.bclary.com/tests/mozilla.org/js/js-test-driver-standards.html?language=type;text/javascript;test=e4x/Regress/regress-354998.js

doesn't work, but

http://test.bclary.com/tests/mozilla.org/js/js-test-driver-standards.html?test=e4x/Regress/regress-354998.js;language=type;text/javascript

does work.

Comment 1

[Bob Clary [:bc] (inactive)]

k.

Comment 2

[Bob Clary [:bc] (inactive)]

Attachment: patch

should allow test=foo, language=bar;value, gczeal=n and jit to be positioned in the querystring.

Comment 3

[Jeff Walden [:Waldo]]

Comment on attachment 353292 [details] [diff] [review]
patch

Is there a reason we can't split on ';', use /^([^=]+)=(.*)$/ and decodeURIComponent to grab names (properties) and values into an object, and then just grab the particular properties we want off that for greatest robustness going forward?  That would also make adding further parameters to the query really easy.

Comment 4

[Jeff Walden [:Waldo]]

Comment on attachment 353292 [details] [diff] [review]
patch

Need an answer to the question in the previous comment still.

Comment 5

[Bob Clary [:bc] (inactive)]

(In reply to comment #4)
> (From update of attachment 353292 [details] [diff] [review])
> Need an answer to the question in the previous comment still.

sorry. I missed that question. No, I think that will work fine. I'll work something up tonight.

Comment 6

[Bob Clary [:bc] (inactive)]

Attachment: patch v2

Comment 7

[Jeff Walden [:Waldo]]

Comment on attachment 354787 [details] [diff] [review]
patch v2

I read through this somewhat skimmily, but basically looks good to me.  Thanks!

Comment 8

[Bob Clary [:bc] (inactive)]

http://hg.mozilla.org/mozilla-central/rev/364b477f377e and cvs.