If you think a bug might affect users in the 57 release, please set the correct tracking and status flags for Release Management.

jsstack.js errors in tracemonkey (JS_FORCES_STACK isn't working)

RESOLVED FIXED

Status

()

Core
Rewriting and Analysis
RESOLVED FIXED
9 years ago
9 years ago

People

(Reporter: Benjamin Smedberg, Assigned: dmandelin)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Reporter)

Description

9 years ago
Tracemonkey with static checking is currently broken:

../../../src/js/src/jsapi.cpp: In function ‘void JS_RestoreFrameChain(JSContext*, JSStackFrame*)’:
../../../src/js/src/jsapi.cpp:5387: error: cannot access JS_REQUIRES_STACK variable JSContext::fp
../../../src/js/src/jsapi.cpp:5392: error: cannot access JS_REQUIRES_STACK variable JSContext::fp
../../../src/js/src/jsapi.cpp: In function ‘JSStackFrame* JS_SaveFrameChain(JSContext*)’:
../../../src/js/src/jsapi.cpp:5378: error: cannot access JS_REQUIRES_STACK variable JSContext::fp
../../../src/js/src/jsapi.cpp: In function ‘JSBool JS_IsRunning(JSContext*)’:
../../../src/js/src/jsapi.cpp:5334: error: cannot access JS_REQUIRES_STACK variable JSContext::fp
../../../src/js/src/jsapi.cpp: In function ‘JSBool js_generic_native_method_dispatcher(JSContext*, JSObject*, uintN, jsval*, jsval*)’:
../../../src/js/src/jsapi.cpp:4585: error: cannot access JS_REQUIRES_STACK variable JSContext::fp

This is an error in the analysis script: it appears that JS_FORCES_STACK isn't actually producing the desired effect. I'm not sure why!

Note: if this isn't fixed by the next tracemonkey->mozilla-central merge, it will cause the static-checking tinderbox to go red.
(Assignee)

Updated

9 years ago
Assignee: nobody → dmandelin
(Assignee)

Comment 1

9 years ago
Created attachment 353288 [details] [diff] [review]
Patch
Attachment #353288 - Flags: review?(jorendorff)
Attachment #353288 - Flags: review?(jorendorff) → review+
(Assignee)

Comment 2

9 years ago
Pushed to gcc-dehydra.
Status: NEW → RESOLVED
Last Resolved: 9 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.