469872 - jsstack.js errors in tracemonkey (JS_FORCES_STACK isn't working)

Status: RESOLVED FIXED

(Developer Infrastructure :: Source Code Analysis, defect)

Description

[Benjamin Smedberg]

Tracemonkey with static checking is currently broken:

../../../src/js/src/jsapi.cpp: In function ‘void JS_RestoreFrameChain(JSContext*, JSStackFrame*)’:
../../../src/js/src/jsapi.cpp:5387: error: cannot access JS_REQUIRES_STACK variable JSContext::fp
../../../src/js/src/jsapi.cpp:5392: error: cannot access JS_REQUIRES_STACK variable JSContext::fp
../../../src/js/src/jsapi.cpp: In function ‘JSStackFrame* JS_SaveFrameChain(JSContext*)’:
../../../src/js/src/jsapi.cpp:5378: error: cannot access JS_REQUIRES_STACK variable JSContext::fp
../../../src/js/src/jsapi.cpp: In function ‘JSBool JS_IsRunning(JSContext*)’:
../../../src/js/src/jsapi.cpp:5334: error: cannot access JS_REQUIRES_STACK variable JSContext::fp
../../../src/js/src/jsapi.cpp: In function ‘JSBool js_generic_native_method_dispatcher(JSContext*, JSObject*, uintN, jsval*, jsval*)’:
../../../src/js/src/jsapi.cpp:4585: error: cannot access JS_REQUIRES_STACK variable JSContext::fp

This is an error in the analysis script: it appears that JS_FORCES_STACK isn't actually producing the desired effect. I'm not sure why!

Note: if this isn't fixed by the next tracemonkey->mozilla-central merge, it will cause the static-checking tinderbox to go red.

Comment 1

[David Mandelin [:dmandelin]]

Attachment: Patch

Comment 2

[David Mandelin [:dmandelin]]

Pushed to gcc-dehydra.