If you think a bug might affect users in the 57 release, please set the correct tracking and status flags for Release Management.

Developer reply to review without title is rejected; comes back escaped

VERIFIED FIXED in 5.5

Status

addons.mozilla.org Graveyard
Public Pages
P3
normal
VERIFIED FIXED
9 years ago
2 years ago

People

(Reporter: Dave Garrett, Assigned: mccammos)

Tracking

unspecified

Details

(URL)

Attachments

(1 attachment)

(Reporter)

Description

9 years ago
Just replied to a review and left the "title" field blank. It didn't like that and told me that the field is required, even though it isn't necessary normally. The body of the reply also came back with escaped quotes and newlines. (i.e. \', \n, etc.) It must not be unescaping it when it comes back to the reply page with the error message.

Comment 1

8 years ago
This problem still exists in current AMO (2/nov/2009)
Priority: -- → P3
Target Milestone: --- → 4.x (triaged)
(Reporter)

Updated

8 years ago
Duplicate of this bug: 528733
(Assignee)

Comment 3

8 years ago
Created attachment 416631 [details] [diff] [review]
Fix
Assignee: nobody → smccammon
Status: NEW → ASSIGNED
Attachment #416631 - Flags: review?(clouserw)
Attachment #416631 - Flags: review?(clouserw) → review+
(Assignee)

Comment 4

8 years ago
r57668
Status: ASSIGNED → RESOLVED
Last Resolved: 8 years ago
Keywords: push-needed
Resolution: --- → FIXED
Target Milestone: 4.x (triaged) → 5.5
Dave, I'm lazy -- mind verifying? :-)
(Reporter)

Comment 6

8 years ago
https://preview.addons.mozilla.org/en-US/firefox/reviews/reply/165313
Escaping is fixed. Try to reply with a blank title and it yells at you with:
"There are errors in this form. Please correct them and resubmit."
and
"This field must not be empty."
with the main review field coming back correctly unescaped.

However, it is still requiring a title. If I then put one in, it still gives me the first error saying there are errors in the form. Apparently I can't post a dev reply at all anymore. REOPENING.
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
(Assignee)

Comment 7

8 years ago
Both replying to and creating new comments fail on preview, yet work just fine on my clean dev copy.

clouserw: is there anything wacky going on with the staging database?
(In reply to comment #7)
> Both replying to and creating new comments fail on preview, yet work just fine
> on my clean dev copy.
> 
> clouserw: is there anything wacky going on with the staging database?

The schema could be out of date if something has changed recently.  I don't know of any system problems.
(Assignee)

Comment 9

8 years ago
Turning debug on revealed the following error when saving a review:

Warning: SQL Error: 1062: Duplicate entry '4294967295' for key 1 

Somehow the reviews table on preview.a.m.o had its auto_increment value maxed out. Clouserw deleted the rogue review with id=4294967295 and reset auto_increment. Reviews can now be saved on preview as expected.
Status: REOPENED → RESOLVED
Last Resolved: 8 years ago8 years ago
Resolution: --- → FIXED
Verified FIXED on https://preview.addons.mozilla.org/en-US/firefox/reviews/reply/165313.
Status: RESOLVED → VERIFIED
Keywords: push-needed
Product: addons.mozilla.org → addons.mozilla.org Graveyard
You need to log in before you can comment on or make changes to this bug.