469899 - Developer reply to review without title is rejected; comes back escaped

Status: VERIFIED FIXED

(addons.mozilla.org Graveyard :: Public Pages, defect, P3)

Description

[Dave Garrett]

Just replied to a review and left the "title" field blank. It didn't like that and told me that the field is required, even though it isn't necessary normally. The body of the reply also came back with escaped quotes and newlines. (i.e. \', \n, etc.) It must not be unescaping it when it comes back to the reply page with the error message.

Comment 1

[Alfred Kayser]

This problem still exists in current AMO (2/nov/2009)

Comment 3

[Scott McCammon [:mccammos]]

Attachment: Fix

Comment 4

[Scott McCammon [:mccammos]]

r57668

Comment 5

[Stephen Donner [:stephend] Not actively reading bugmail]

Dave, I'm lazy -- mind verifying? :-)

Comment 6

[Dave Garrett]

https://preview.addons.mozilla.org/en-US/firefox/reviews/reply/165313
Escaping is fixed. Try to reply with a blank title and it yells at you with:
"There are errors in this form. Please correct them and resubmit."
and
"This field must not be empty."
with the main review field coming back correctly unescaped.

However, it is still requiring a title. If I then put one in, it still gives me the first error saying there are errors in the form. Apparently I can't post a dev reply at all anymore. REOPENING.

Comment 7

[Scott McCammon [:mccammos]]

Both replying to and creating new comments fail on preview, yet work just fine on my clean dev copy.

clouserw: is there anything wacky going on with the staging database?

Comment 8

[Wil Clouser [:clouserw]]

(In reply to comment #7)
> Both replying to and creating new comments fail on preview, yet work just fine
> on my clean dev copy.
> 
> clouserw: is there anything wacky going on with the staging database?

The schema could be out of date if something has changed recently.  I don't know of any system problems.

Comment 9

[Scott McCammon [:mccammos]]

Turning debug on revealed the following error when saving a review:

Warning: SQL Error: 1062: Duplicate entry '4294967295' for key 1 

Somehow the reviews table on preview.a.m.o had its auto_increment value maxed out. Clouserw deleted the rogue review with id=4294967295 and reset auto_increment. Reviews can now be saved on preview as expected.

Comment 10

[Stephen Donner [:stephend] Not actively reading bugmail]

Verified FIXED on https://preview.addons.mozilla.org/en-US/firefox/reviews/reply/165313.