470019 - Expose DOMWindow

Status: RESOLVED FIXED

(Core Graveyard :: Embedding: APIs, defect)

Description

[Tobias Hunger]

User-Agent:       Mozilla/5.0 (X11; U; Linux i686; de; rv:1.9.0.1) Gecko/2008070400 SUSE/3.0.1-1.1 Firefox/3.0.1
Build Identifier: hg rev. 43a4f0d6d89e

Expose the DOMWindow in MozView so that other classes can use it.

This is meant for use internal to the embedding API only and should not get passed through the platform specific wrappers!

Reproducible: Always

Comment 1

[Tobias Hunger]

Attachment: domwindow exposal patch

Comment 2

[Mark Finkle (:mfinkle) (use needinfo?)]

Comment on attachment 353463 [details] [diff] [review]
domwindow exposal patch

Can you update this with the new DOMEventListener change?

Also, I used mDOMEventListener in that patch. Could you change to mDOMWindow?

Comment 3

[Tobias Hunger]

Attachment: domwindow exposal patch

Update the patch to the newest hg revision and incorporate changes suggested by mark.

Comment 4

[Tobias Hunger]

Comment on attachment 353662 [details] [diff] [review]
domwindow exposal patch

Further move most of the cleanup code out of the patch by depending on #470201.

Comment 5

[Anton Rogaynis (antonr)]

would be nice to update 
+    if (!NS_SUCCEEDED(mPrivate->mWebBrowser->GetContentDOMWindow(getter_AddRefs(domWindow))))

to

+    if (NS_FAILED(mPrivate->mWebBrowser->GetContentDOMWindow(getter_AddRefs(domWindow))))

to avoid another clean up patch ;)

Comment 6

[Tobias Hunger]

Attachment: domwindow exposal patch v1.1

Anton is right: Replaced !NS_SUCCEEDED with NS_FAILED.

Comment 7

[Tobias Hunger]

Attachment: domwindow exposal patch v1.2

Sorry, I just added the wrong patch with the last update.

I got too many patches in too many versions sitting on my disk right now:-(

This one is exactly the patch Mark already approved with the one change Anton suggested.

Comment 8

[Mark Finkle (:mfinkle) (use needinfo?)]

http://hg.mozilla.org/incubator/embedding/rev/cf15dc012b32