470034 - Personal Toolbar doesn't respect the toolbar icon/test mode controls

Status: RESOLVED WONTFIX

(SeaMonkey :: UI Design, enhancement)

Description

[Ed Mullen]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.1b3pre) Gecko/20081202 SeaMonkey/2.0a2
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.1b3pre) Gecko/20081202 SeaMonkey/2.0a2

Right-click on the Personal Toolbar outside of an actual bookmark item.  On the resulting pop-up menu select "Settings for this toolbar".  Select "Text" item.

I would expect the PTB icons to disappear.  They do not.  Even after reboot the icons are there and the "Text" item is still selected in the context menu.

Reproducible: Always

Steps to Reproduce:
1.  Right-click PTB
2.  Settings for this toolbar
3.  Select "Text" item (expecting the PTB icons to no longer display)
Actual Results:  
The icons are still visible in the PTB.

Expected Results:  
The icons should disappear leaving only text descriptors for the PTB items.

The workaround is to place the following in the userChrome.css file:

/* Kill bookmark icons in the Personal Toolbar */
toolbarbutton.bookmark-item > .toolbarbutton-icon {
  display: none !important;
}
/* END Kill bookmark icons in the Personal Toolbar */

Comment 1

[Philip Chee]

The toolbar buttons in the Personal Toolbar (e.g. home button) do respect the settings. The two problems are:
1. The bookmark items widget is a toolbarITEM not a toolbar button.
2. Historically the bookmark items weren't configurable at all.

Comment 2

[Philip Chee]

I am working on this as part of Bug 470417. See: <https://bugzilla.mozilla.org/show_bug.cgi?id=470417#c1>

Comment 3

[Philip Chee]

From <https://bugzilla.mozilla.org/show_bug.cgi?id=470417#c3>

> (From update of attachment 353808 [details] [diff] [review])
> r=me except on the bookmark icon changes - I think we need to be able to
> differentiate between folders and bookmarks.

So I guess the module owner doesn't agree with allowing the bookmark-item icons to be hidden.

Comment 4

[Philip Chee]

"bookmarks shouldn't change whichever toolbar they're in"
=> WONTFIX as per IRC comment from Neil

Comment 5

[Ed Mullen]

(In reply to comment #4)
> "bookmarks shouldn't change whichever toolbar they're in"
> => WONTFIX as per IRC comment from Neil

Then shouldn't the option be removed from the UI?  Hardly makes sense to have a non-functional option in the UI.

Comment 6

[Philip Chee]

What option? There's no option specific to the bookmark-items widget.