Closed Bug 470165 Opened 11 years ago Closed 11 years ago

Cleanup the GTK nsFilePicker code

Categories

(Core :: Widget: Gtk, defect)

x86
Linux
defect
Not set

Tracking

()

RESOLVED FIXED
mozilla1.9.2a1

People

(Reporter: ventnor.bugzilla, Assigned: ventnor.bugzilla)

Details

Attachments

(1 file)

It still dynamically links the GTK library. It still does versioning checks for GTK 2.4, despite the fact we rely on GTK 2.10 now. This code needs a lot of love to make it easier to read and modify.
Attachment #353621 - Flags: superreview?(roc)
Attachment #353621 - Flags: review?(roc)
Attachment #353621 - Flags: superreview?(roc)
Attachment #353621 - Flags: superreview+
Attachment #353621 - Flags: review?(roc)
Attachment #353621 - Flags: review+
Keywords: checkin-needed
Whiteboard: [needs landing]
Comment on attachment 353621 [details] [diff] [review]
Patch
[Checkin: Comment 1]

http://hg.mozilla.org/mozilla-central/rev/4e2eb5e11585
Attachment #353621 - Attachment description: Patch → Patch [Checkin: Comment 1]
Status: NEW → RESOLVED
Closed: 11 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Whiteboard: [needs landing]
Target Milestone: --- → mozilla1.9.2a1
You need to log in before you can comment on or make changes to this bug.