470181 - test_idcheck.xul : console.xul has 4 duplicates on m-c (1.9.2)

Status: VERIFIED FIXED

(Core Graveyard :: Error Console, defect)

Description

[Serge Gautherie (:sgautherie)]

[Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.9.1b3pre) Gecko/20081218 SeaMonkey/2.0a2pre] (home, optim default) (W2Ksp4)
(http://hg.mozilla.org/mozilla-central/rev/18ecd1a5fd1d
 +http://hg.mozilla.org/comm-central/rev/1c26ea5bb33d)

No duplicates.

[Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.9.2a1pre) Gecko/20081217 SeaMonkey/2.0a3pre] (home, optim default) (W2Ksp4)
(http://hg.mozilla.org/mozilla-central/rev/4a4a42520901
 +http://hg.mozilla.org/comm-central/rev/877154dd96a2 + bug 469606 patch)

{
1149 INFO TEST-PASS | chrome://mochikit/content/chrome/suite/common/tests/chrome/test_idcheck.xul | check id: console.xul#viewGroup
1150 INFO TEST-PASS | chrome://mochikit/content/chrome/suite/common/tests/chrome/test_idcheck.xul | check id: console.xul#Console:modeAll
1151 INFO TEST-PASS | chrome://mochikit/content/chrome/suite/common/tests/chrome/test_idcheck.xul | check id: console.xul#Console:modeErrors
1152 INFO TEST-PASS | chrome://mochikit/content/chrome/suite/common/tests/chrome/test_idcheck.xul | check id: console.xul#Console:modeWarnings
1153 INFO TEST-PASS | chrome://mochikit/content/chrome/suite/common/tests/chrome/test_idcheck.xul | check id: console.xul#Console:modeMessages
1154 INFO TEST-PASS | chrome://mochikit/content/chrome/suite/common/tests/chrome/test_idcheck.xul | check id: console.xul#Console:clear
1155 ERROR TEST-UNEXPECTED-FAIL | chrome://mochikit/content/chrome/suite/common/tests/chrome/test_idcheck.xul | check id: console.xul#Console:modeAll
1156 ERROR TEST-UNEXPECTED-FAIL | chrome://mochikit/content/chrome/suite/common/tests/chrome/test_idcheck.xul | check id: console.xul#Console:modeErrors
1157 ERROR TEST-UNEXPECTED-FAIL | chrome://mochikit/content/chrome/suite/common/tests/chrome/test_idcheck.xul | check id: console.xul#Console:modeWarnings
1158 ERROR TEST-UNEXPECTED-FAIL | chrome://mochikit/content/chrome/suite/common/tests/chrome/test_idcheck.xul | check id: console.xul#Console:modeMessages
1159 INFO TEST-PASS | chrome://mochikit/content/chrome/suite/common/tests/chrome/test_idcheck.xul | check id: console.xul#ToolbarEval
}

Comment 1

[Serge Gautherie (:sgautherie)]

Attachment: Detailed log

[Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.9.2a1pre) Gecko/20081217 SeaMonkey/2.0a3pre] (home, optim default) (W2Ksp4)
(http://hg.mozilla.org/mozilla-central/rev/4a4a42520901
 +http://hg.mozilla.org/comm-central/rev/877154dd96a2 + bug 469606 patch)

See "hbox viewGroup [0]" <-> "toolbar ToolbarMode [1]".

Comment 2

[Philip Chee]

Translating Serge speak into normal English this means that the check-in for Bug 456214 <http://hg.mozilla.org/mozilla-central/rev/5090a2e23f6b> added an additional <hbox id="viewGroup" chromedir="&locale.dir;"> around the toolbar buttons. Causing the wheels on our consoleOverlay.xul to fall off.

At the moment this patch is mozilla central only but will be making it's way to 1.9.1. Real Soon Now[TM]

Comment 3

[Serge Gautherie (:sgautherie)]

This is visible on the Error Console as a 2nd set of these 4 icons, but without their labels.

Comment 4

[[e-mail]]

(In reply to comment #2)
> the check-in for bug 456214 added an additional <hbox id="viewGroup"
> chromedir="&locale.dir;"> around the toolbar buttons.
Well, around those four in question, yes.

Comment 5

[[e-mail]]

Or the alternative is to stop using deep nesting, and just put standalone toolbar and toolbarbutton elements at the top level in the overlay. This would work with both the old and new console.xul versions.

Comment 6

[Stefan [:stefanh]]

Attachment: fix overlay

I used the nested way, because I figured not doing it would require more changes in the file and it felt like it'd be easier to understand what's going on in the overlay when doing it the nested way. I think I scared Markus earlier when I showed him a screenshot of a broken button, but that was because I didn't noticed that I had messed up and created 2 Clear buttons ;-)

Comment 7

[Stefan [:stefanh]]

I forgot to mention that if this gets r+sr, it needs to be synced with the 191 landing of the patch in bug 456214.

Comment 8

[Stefan [:stefanh]]

I'm going to land this later on today/tonight, after the patch in bug 456214 has landed on 191. The worst thing that can happen is that there will be a few hours slip (because I'll be away for a couple of hours), but I think we can live with that.

Comment 9

[Stefan [:stefanh]]

http://hg.mozilla.org/comm-central/rev/9b6855526bb6

Comment 10

[Serge Gautherie (:sgautherie)]

[Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.9.2a1pre) Gecko/20090110
SeaMonkey/2.0a3pre] (experimental/_m-c_, home, optim default) (W2Ksp4)
(http://hg.mozilla.org/mozilla-central/rev/6acaaa957e0a
 +http://hg.mozilla.org/comm-central/rev/865f907bb16b)

V.Fixed