All add-on versions get sandboxed after new submission

VERIFIED FIXED in 4.0.5

Status

--
blocker
VERIFIED FIXED
10 years ago
3 years ago

People

(Reporter: aryx, Assigned: fligtar)

Tracking

Details

Attachments

(1 attachment)

All add-on versions get sandboxed after new submission. Maybe the latest public version has to be very new or it's related to the code removing older versions from the pending update queue.

Examples:
AutoPager https://addons.mozilla.org/en-US/firefox/addon/4925
VertTabbar https://addons.mozilla.org/en-US/firefox/addon/8045

Comment 1

10 years ago
For AutoPager, the last public version was released at November 9, 2008. The new version was uploaded at December 17, 2008.
Looking at r20493, that's the culprit here. Raising severity as it will gradually screw up a lot of add-ons if it stays like this :-/

Fligtar, are you around to fix that code?
Assignee: nobody → fligtar
Severity: critical → blocker
Target Milestone: --- → 4.0.5
By the way what *may* fix this is adding a "WHERE file.status = pending" to the SQL query. Currently you just mark *all* of the addon's files as sandboxed which is clearly not what the code intends to do.
(Assignee)

Comment 4

10 years ago
Created attachment 353717 [details] [diff] [review]
patch
Attachment #353717 - Flags: review?(fwenzel)
Comment on attachment 353717 [details] [diff] [review]
patch

Yup, that looks like it should prevent the breakage.
Attachment #353717 - Flags: review?(fwenzel) → review+
(Assignee)

Comment 6

10 years ago
r21087.
Status: NEW → RESOLVED
Last Resolved: 10 years ago
Keywords: push-needed
Resolution: --- → FIXED
Wind, any chance you wouldn't mind verifying this as fixed using https://preview.addons.mozilla.org/en-US/developers?

Comment 8

10 years ago
(In reply to comment #7)
> Wind, any chance you wouldn't mind verifying this as fixed using
> https://preview.addons.mozilla.org/en-US/developers?

It works fine now.
I just upload a new version. Changed the max firefox version. Just as what I did in addons.mozilla.org.
All the public files still public.

Thanks for the quick fix.
Wind
Thanks for being patient and for helping with the verification, Wind!

Verified FIXED.
Status: RESOLVED → VERIFIED

Comment 10

10 years ago
Are we taking any action with respect to add-ons that already got hit. Looks, for example, like https://addons.mozilla.org/en-US/firefox/addons/versions/5447 got hit, too?

Comment 11

10 years ago
Crap. I just got hit by this. Didn't realize this wasn't pushed yet...
https://addons.mozilla.org/en-US/firefox/addons/versions/5791

Comment 12

10 years ago
Not to be a nag, but is there a reason why this fix hasn't been pushed yet? My public page was broken for a bit until Gijs was nice enough to review the new version for me. (no public versions for public add-on -> no download button and quite broken page) Would be nice to get this on production asap so as to not break things like this for anyone else.

And as to the other re-sandboxed versions, that needs another bug I guess? Is there a way to do it automatically or will someone have to go in and re-approve whole scores at once? (28 old versions in my case)

Comment 13

10 years ago
Not notice this hadn't been deployed. I just hit by this another time.   :'(
I've filed bug 471200 to get this pushed and 471201 to fix the broken add-ons.

Updated

10 years ago
Blocks: 471201
Keywords: push-needed

Comment 15

10 years ago
Thanks
Product: addons.mozilla.org → addons.mozilla.org Graveyard
You need to log in before you can comment on or make changes to this bug.