470210 - getAddonsController and getPreferencesController should support Thunderbird as well

Status: RESOLVED FIXED

(Testing Graveyard :: Mozmill, defect)

Description

[Gary Kwong [:gkw] [:nth10sd] (NOT official MoCo now)]

getAddonsController and getPreferencesController should work in Thunderbird too, instead of Thunderbird having to write their own functions for it.

Comment 1

[Gary Kwong [:gkw] [:nth10sd] (NOT official MoCo now)]

Thunderbird calls openAddonsMgr() to get to the addons manager, while Firefox calls BrowserOpenAddonsMgr(). For preferences TB calls openOptionsDialog I think, though I could be wrong about this one.

Should this be solved by forking TB's version of getTBAddonsController() (which calls openAddonsMgr()) or by adding some form of app detection into getAddonsController() ?

See approximately
http://mxr.mozilla.org/comm-central/source/mail/base/content/mailCore.js#199

Comment 2

[Mikeal Rogers [:mikeal] (mrogers@)]

Can someone point me at some code that can do app detection?

We should just have conditionals to support this via app detection in mozmill.js

Comment 3

[Adrian Kalla [:adriank]]

Regarding Comment #2:

especially, because Sunbird uses goOpenAddons() to open the addons manager, and SeaMonkey toEM()

Comment 4

[Mikeal Rogers [:mikeal] (mrogers@)]

I added sunbird and thunderbird support for getAddonsController but I need to know the functions it uses for pulling up the preferences window if I'm going to add support for the same.

Comment 5

[Mark Banner (:standard8)]

Sunbird seems to use openPreferences()

http://mxr.mozilla.org/comm-central/source/calendar/resources/content/calendar.js#172

Thunderbird uses openOptionsDialog()

http://mxr.mozilla.org/comm-central/source/mail/base/content/mailCore.js#199 (no params necessary)

Nice and consistent aren't we :-/

Comment 6

[Mikeal Rogers [:mikeal] (mrogers@)]

Fixed in r369.