Closed Bug 470228 Opened 14 years ago Closed 14 years ago

[A-2] Extension icons

Categories

(addons.mozilla.org Graveyard :: Collector Extension, defect)

defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: kinger, Assigned: kinger)

References

()

Details

Attachments

(12 files, 1 obsolete file)

The icons at the bottom left of the Feeds pane were swiped from elsewhere in
Firefox (Windows).

This bug is about:

1) Requesting new images, or making them.

2) Integrating them upon receipt.

These icons should have normal and hover state, size 16x16.

We also need a new icon for the Add-ons Windows listing (32x32)
Attached image Current Icons (obsolete) —
Here is a screen grab of what the icons look like currently.

1. From left; Add Collection, Reload all collections, Settings.

2. Feeds icon that is also the extension icon.
Target Milestone: --- → BW-M3
I talked with Faaborg a bit about this. The main factor to consider in getting icons is whether we'll be doing platform-specific themes.

I think it's probably OK to try out just using one set of icons on all platforms. Alex said he thinks we have the 3 needed icons in one set available already.

Alex, would you mind attaching them here?
Hardware: x86 → All
Summary: Collections Extension: New Icons → [A-2] Extension icons
I've asked Sean Martell to design some icons for us. In the meantime, we can continue using the placeholders.
Attached image plus sign
Attachment #353687 - Attachment is obsolete: true
Attached image reload
Attached image gear
Attached image extension icon
Brian - 3 new button icons attached, to be used on all platforms. Also included the new extension icon.

I still need to get you the platform-specific icons for E-1.8.3
Thanks, I integrated those. Also consider a minus icon to compliment the plus one. Right now the settings window has both to add/remove a collection. Is this still required in that context?
Also consider 3 new icons for the panels in Options. For more details see:
https://bugzilla.mozilla.org/attachment.cgi?id=365663

Specs:
- 32x32
- PNG preferred
- 2 states for each, normal and active/hover
- A composite of all 6 would be ideal, but not compulsory
Attached image toolbar icon reference
This is a reference to show which toolbar icon goes on which platform
Attached image toobar icons
These are the actual toolbar icons
Okay, the remaining icons needed that I'm aware of are:
- comment icon that indicates when the publisher has commented on an add-on in a collection
- icon for the auto-publisher synced with the current profile
- preferences panel icons for Manage Subscriptions, General Settings, and Auto-publisher Settings
Brian, for the preferences dialog, is there any reason we couldn't use a few of the placeholder icons permanently? I'm not sure where you got them from, which is why I'm asking, but I think we could use the cog for "General Settings", the Bandwagon logo for "Manage Subscriptions", and I can have an icon made for Auto-publisher Settings. Thoughts?
If we go with that, I could of course have active/hover states made for the placeholders as well.
(In reply to comment #14)
> Brian, for the preferences dialog, is there any reason we couldn't use a few of
> the placeholder icons permanently? I'm not sure where you got them from, which
> is why I'm asking, but I think we could use the cog for "General Settings", the
> Bandwagon logo for "Manage Subscriptions", and I can have an icon made for
> Auto-publisher Settings. Thoughts?

The cog is the icon used in the Advanced tab in the Firefox Options window:

radio[pane=paneAuto] {
  list-style-image: url("chrome://browser/skin/preferences/Options.png"); 
  -moz-image-region: rect(0px, 224px, 32px, 192px)
}

Currently we are at the mercy of themes if we leave that rule as is. I suppose we could crop it out from each of the default platform themes and use it per-platform like we do the toolbar button. What do you think?

I forget where the star came from. I just found a larger version from before in the skin/ folder and scaled it for use here. A new icon for Auto-publisher Settings is fine.
Okay, I've asked Sean for:
1) publisher comments indicator
2) synced auto-publisher icon
3) active/hover state for Bandwagon logo button, and normal + active/hover state for auto-publisher preferences pane

He's not sure when he'll have time to get to those, but in the meantime, let's:
- move Bandwagon icon to Manage Subscriptions
- Move options cog to General Settings, and add active/hover state since that's already available. Let's copy the cog from the options png.
- Move star to auto-publisher prefs so that we can just replace that with the new icon when it's ready
FMI, for Gear icons:

0 32 32 0
t   r    b  l
0 64 32 32
32 64 64 32

0 96 32 64
32 96 64 64

0 128 32 96
32 128 64 96
(In reply to comment #17)
> He's not sure when he'll have time to get to those, but in the meantime, let's:
> - move Bandwagon icon to Manage Subscriptions
> - Move options cog to General Settings, and add active/hover state since that's
> already available. Let's copy the cog from the options png.
> - Move star to auto-publisher prefs so that we can just replace that with the
> new icon when it's ready

Done.
Attached image comment icon
Comment icon. OSX, Vista, XP, Tango
icon to designate the auto-publisher associated with the current profile. OSX, Vista, XP, Tango
Auto-publisher preferences icon. OSX, Vista, XP, Tango
Attached image general settings icon
Let's use the same icon Firefox uses for General Settings instead of the gear.

OSX, Vista, XP, Tango
icon for Manage Subscriptions pane.

first is normal state, second is hover/active in XP, third is hover/active in OS X. Vista and Tango have no hover.
I think that's all the icons. Is there anything else you need from me, Brian?
Assignee: fligtar → brian
(In reply to comment #26)
> I think that's all the icons. Is there anything else you need from me, Brian?

Can't think of anything right now.

The new prefs icons are in.
Over to Dave for comment icon and auto-publisher designation icon integration.
Assignee: brian → dave
Actually I'll handle the rest.
Assignee: dave → brian
Auto-publisher icon in, revision 24263.

Only comment icons to do. I can't see comments in any of the listings however.
Status: NEW → ASSIGNED
Depends on: 487427
Moving to revised M5 milestone (4/28).
Target Milestone: BW-M3 → BW-M5
Comment icons are in, revision 24684. I think that wraps up this bug.
Status: ASSIGNED → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
Component: Collections → Collector Extension
QA Contact: collections → collector-extension
Product: addons.mozilla.org → addons.mozilla.org Graveyard
You need to log in before you can comment on or make changes to this bug.