Closed Bug 470245 Opened 16 years ago Closed 15 years ago

Collections Extension: Update feed / feedItem unserializer to support extra fields (API to be defined)

Categories

(addons.mozilla.org Graveyard :: Collector Extension, defect)

Product:
addons.mozilla.org Graveyard
Component:
Collector Extension
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED

People

(Reporter: kinger, Assigned: mackers)

References

Details

We are expecting the following info in the new API:

- feed:  name
- feed: site url
- addon: author
- addon: category
- addon: when added
- addon: comments
Target Milestone: --- → BW-M3
Most of the required info is now available to us.

We seem to be still missing:

- The collection's site url.
- The collection's icon url.
- The collection's creator.
- The addon's comment's author.
What we now have:

- Site url. We're using this in the "View Site" link at the top of every colleciton.

What we're waiting for:

- Creator. This field seems to be always blank in the API response.
- Icon url: No sign of this anywhere.
- The addon's comment's author. This field seems to be always blank in the API response.
Blocks: 481149
Les, can you take a look at these missing fields?
Assignee: dave → lorchard
Hardware: x86 → All
- Collection icon url: What should this be?  Haven't heard of it before now.

- Addon comment author: Before fixes in a patch for bug 481149, the web UI scaffolding wasn't storing comment author info in the DB.  So, there's no way to get that info for addons added to collections before the patch.  It appears to be working for addons added to collections since the patch.

- Collection creator: I see creator for collections in API responses.  Can you give me a specific example where it isn't?

This is what I see for a collection I just created and added to - tell me what's missing:

/usr/bin/curl -sD - -X GET -k -u'lorchard@mozilla.com:MYPASSWORD' 'https://bandwagon.stage.mozilla.com/en-US/firefox/api/1.1/sharing/collections/845565b4-6962-102c-9a23-001e0bd9232c'

HTTP/1.0 200 OK
Date: Tue, 24 Mar 2009 20:04:50 GMT
Expires: Tue, 24 Mar 2009 20:59:06 GMT
Cache-Control: max-age=3600      ,public
Connection: Keep-Alive
Via: NS-CACHE-6.0:   4
Server: Apache/2.2.3 (Red Hat)
X-Powered-By: PHP/5.1.6
X-AMO-ServedBy: mrapp-stage02
Last-Modified: Tue, 24 Mar 2009 19:59:06 GMT
Content-Length: 6650
Content-Type: text/xml

<?xml version="1.0" encoding="utf-8" ?>
<collection xmlns="http://addons.mozilla.org/" 
    xml:base="https://bandwagon.stage.mozilla.com/en-US/firefox/api/1.1/sharing/collections/845565b4-6962-102c-9a23-001e0bd9232c"
    name="play"
    type="normal"
    description="play"
    creator="l.m.orchard"
    listed="yes" writable="yes" subscribed="no" 
    lastmodified="2009-03-24T12:59:06-07:00">

    <links xml:base="https://bandwagon.stage.mozilla.com/en-US/firefox/">
        <link id="view" href="collections/view/845565b4-6962-102c-9a23-001e0bd9232c" />
        <link id="subscribe" href="collections/subscribe/845565b4-6962-102c-9a23-001e0bd9232c" />
        <link id="unsubscribe" href="collections/unsubscribe/845565b4-6962-102c-9a23-001e0bd9232c" />
    </links>

    <addons href="addons/">
        
    
<addon href="addons/%7BD4DD63FA-01E4-46a7-B6B1-EDAB7D6AD389%7D/">
    <meta>
        <added>2009-03-24T12:59:06-07:00</added>
        <addedby>l.m.orchard</addedby>
        <comments></comments>
            </meta>
    <categories>
            <category id="5">Download Management</category>
        </categories>
    <name>Download Statusbar</name>
    <type id='1'>Extension</type>
    <guid>{D4DD63FA-01E4-46a7-B6B1-EDAB7D6AD389}</guid>
    <version>47342</version>
    <status id='4'>Public</status>
    <authors>
          <author>Devon Jensen</author>
    </authors>      
    <summary>View and manage downloads from a tidy statusbar - without the download window getting in the way of your web browsing.</summary>
    <description>Despite its compact size, Download Statusbar packs in more useful features than the standard download window. The fully customizable interface auto-hides when not in use, allowing full control without interruption.  

Be sure to check out the preview images!</description>
    <icon>https://addons.mozilla.org/img/default_icon.png</icon>
    <compatible_applications>
            <application>
            <name>Firefox</name>
            <application_id>1</application_id>
            <min_version>2.0</min_version>
            <max_version>3.1b2pre</max_version>
            <appID>{ec8030f7-c20a-464f-9b0e-13a3a9e97384}</appID>
             </application>
         </compatible_applications>      
        <all_compatible_os>
            <os>ALL</os>
                    </all_compatible_os>
        <eula></eula>
    <thumbnail>https://addons.mozilla.org/en-US/firefox/images/t/9395/1174607013</thumbnail>
    <rating>5</rating>
    <learnmore>https://addons.mozilla.org/addon/26</learnmore>
             <install hash='sha256:3287737ca3b946576ce7362005392f339268431296b34f92fda18fc14fd64d6e' os='ALL'>https://addons.mozilla.org/downloads/file/30823/download_statusbar-0.9.6.3-fx.xpi</install>          
         </addon>
    
    
<addon href="addons/%7Bfc76dc89-03b7-47fe-ab1d-b317b062bba8%7D/">
    <meta>
        <added>2009-03-24T12:58:49-07:00</added>
        <addedby>l.m.orchard</addedby>
        <comments></comments>
            </meta>
    <categories>
            <category id="13">Search Tools</category>
            <category id="38">Photos, Music &amp; Videos</category>
            <category id="71">Social &amp; Communication</category>
            <category id="73">Other</category>
        </categories>
    <name>Xoopit for Gmail</name>
    <type id='1'>Extension</type>
    <guid>{fc76dc89-03b7-47fe-ab1d-b317b062bba8}</guid>
    <version>56831</version>
    <status id='4'>Public</status>
    <authors>
          <author>The Xoopit Team</author>
    </authors>      
    <summary>Use Gmail? Get Xoopit! Upgrade Gmail to search, browse &amp; share files, photos &amp; videos. Use Google Search while composing mail in Gmail. Get information about people in a Gmail conversation. Xoopit works for Gmail, Google Mail and Google Apps users.</summary>
    <description>Xoopit for Gmail lets you:
* Search your stuff, not your messages. Xoopit upgrades Gmail search to show you the photos, videos and files that match what you are looking for.
* Browse photos and videos from YouTube, Flickr, Shutterfly, Kodak and Picasa. Links sent to your Gmail account are automatically collected, saving you the hassle of going to these sites.
* Easily find and access your files in Gmail. Never misplace an attachment again.
* Quick share to friends, Facebook or your blog.
* Do a web search while composing a mail in Gmail and add results directly to your message.
* Get information, contact details and more about the people in Gmail&#39;s conversation view.

View demos of Xoopit:
* http://www.vimeo.com/1946762 - PopSiren demos Xoopit
* http://www.xoopit.com/press/video-gmail-media-search

Frequently Asked Questions:
1. Can I use the Xoopit for Gmail plugin without a Xoopit account? 
  Yes! You can use Xoopit&#39;s Compose Search and Conversation People features without signing up for the Xoopit service. You will not be able to view, search and send around the photos, files and videos in your mail.

2. When I sign up for Xoopit, why am I asked for my Gmail username and password?
  Xoopit requires your Gmail username and password in order to find and index the photos, videos and files in your Gmail. Xoopit works like other mail clients connecting to Gmail, such as your desktop mail program or cell phone. 

3. I have more privacy and security questions. Where do I find out more?
  We are intently focused on protecting your privacy. Xoopit uses industrial-strength encryption and secure connections to Gmail as well as secure data storage to ensure your data remains private.  Find out more at http://www.xoopit.com/privacy-and-security.</description>
    <icon>https://addons.mozilla.org/en-US/firefox/images/addon_icon/8257/1226079857</icon>
    <compatible_applications>
            <application>
            <name>Firefox</name>
            <application_id>1</application_id>
            <min_version>1.5</min_version>
            <max_version>3.1b2pre</max_version>
            <appID>{ec8030f7-c20a-464f-9b0e-13a3a9e97384}</appID>
             </application>
         </compatible_applications>      
        <all_compatible_os>
            <os>ALL</os>
                    </all_compatible_os>
        <eula></eula>
    <thumbnail>https://addons.mozilla.org/en-US/firefox/images/t/24060/1225430716</thumbnail>
    <rating>4</rating>
    <learnmore>https://addons.mozilla.org/addon/8257</learnmore>
             <install hash='sha256:cd95d444c2cd3fe3e9972d2052a0ec12a86ab8ffa64347dfea5ffb74c1d2feba' os='ALL'>https://addons.mozilla.org/downloads/file/40714/xoopit_for_gmail-1.0.11406-fx.xpi</install>          
         </addon>
    
    </addons>

</collection>
(In reply to comment #4)
> - Collection icon url: What should this be?  Haven't heard of it before now.
> 

Hmm, I guess this wasn't added in the creation scaffolding. So that we have something returned in the API that the extension can use, can we clone the getAddonIconURL() method in the image component to return a collection icon URL similiar to addon_icon?

And if there is no collection icon uploaded, the default should be the Bandwagon logo: https://bug470228.bugzilla.mozilla.org/attachment.cgi?id=365102
(In reply to comment #4)
> - Collection creator: I see creator for collections in API responses.  Can you
> give me a specific example where it isn't?
> 
> This is what I see for a collection I just created and added to - tell me
> what's missing:

This is what I get for a collection that I just created and added an add-on to. Note the creator field (and incidentally addedby field) is empty.


bandwagon(5): Bandwagon.RPC.Net.send.onreadystatechange: 686937421881588: completed, response text = '<?xml version="1.0" encoding="utf-8" ?>
<collection xmlns="http://addons.mozilla.org/" 
    xml:base="https://bandwagon.stage.mozilla.com/en-US/firefox/api/1.3/sharing/collections/d23f34af-8772-f175-93a9-93ba047d369d/"
    name="testcollection123"
    type="normal"
    description="just testing..."
    creator=""
    listed="no" writable="yes" subscribed="no" 
    lastmodified="2009-03-30T07:35:15-07:00">

    <links xml:base="https://bandwagon.stage.mozilla.com/en-US/firefox/">
        <link id="view" href="collections/view/d23f34af-8772-f175-93a9-93ba047d369d" />
        <link id="subscribe" href="collections/subscribe/d23f34af-8772-f175-93a9-93ba047d369d" />
        <link id="unsubscribe" href="collections/unsubscribe/d23f34af-8772-f175-93a9-93ba047d369d" />
    </links>

    <addons href="addons/">
        
    
<addon href="addons/%7Bc45c406e-ab73-11d8-be73-000a95be3b12%7D/">
    <meta>
        <added>2009-03-30T07:35:15-07:00</added>
        <addedby></addedby>
        <comments>meow123</comments>
            </meta>
    <categories>
            <category id="4">Web Development</category>
        </categories>
    <name>Web Developer</name>
    <type id='1'>Extension</type>
    <guid>{c45c406e-ab73-11d8-be73-000a95be3b12}</guid>
    <version>45230</version>
    <status id='4'>Public</status>
    <authors>
          <author>Chris Pederick</author>
    </authors>      
    <summary>Adds a menu and a toolbar with various web developer tools.</summary>
    <description>Adds a menu and a toolbar with various web developer tools.</description>
    <icon>https://addons.mozilla.org/en-US/firefox/images/addon_icon/60/1211254666</icon>
    <compatible_applications>
            <application>
            <name>Firefox</name>
            <application_id>1</application_id>
            <min_version>1.0</min_version>
            <max_version>3.0.*</max_version>
            <appID>{ec8030f7-c20a-464f-9b0e-13a3a9e97384}</appID>
             </application>
         </compatible_applications>      
        <all_compatible_os>
            <os>ALL</os>
                    </all_compatible_os>
        <eula></eula>
    <thumbnail>https://addons.mozilla.org/en-US/firefox/images/t/11916/943948800</thumbnail>
    <rating>5</rating>
    <learnmore>https://addons.mozilla.org/addon/60</learnmore>
             <install hash='sha256:4d62c52037271b2e44c818a2d824ea920cff8ef9477bb78a3c1828b7a5ecf1f9' os='ALL'>https://addons.mozilla.org/downloads/file/28678/web_developer-1.1.6-fx.xpi</install>          
         </addon>
    
    
<addon href="addons/firebug%40software.joehewitt.com/">
    <meta>
        <added>2009-03-30T07:31:14-07:00</added>
        <addedby></addedby>
        <comments></comments>
            </meta>
    <categories>
            <category id="4">Web Development</category>
        </categories>
    <name>Firebug</name>
    <type id='1'>Extension</type>
    <guid>firebug@software.joehewitt.com</guid>
    <version>53821</version>
    <status id='4'>Public</status>
    <authors>
          <author>Joe Hewitt</author>
          <author>Justin Dolske</author>
          <author>robcee</author>
    </authors>      
    <summary>Firebug integrates with Firefox to put a wealth of development tools at your fingertips while you browse. You can edit, debug, and monitor CSS, HTML, and JavaScript live in any web page...

Firebug 1.2 requires Firefox 2 or 3.</summary>
    <description>Firebug integrates with Firefox to put a wealth of development tools at your fingertips while you browse. You can edit, debug, and monitor CSS, HTML, and JavaScript live in any web page.

Visit the Firebug website for documentation, screen shots, and discussion forums: http://getfirebug.com
</description>
    <icon>https://addons.mozilla.org/en-US/firefox/images/addon_icon/1843/1221241568</icon>
    <compatible_applications>
            <application>
            <name>Firefox</name>
            <application_id>1</application_id>
            <min_version>2.0</min_version>
            <max_version>3.0.*</max_version>
            <appID>{ec8030f7-c20a-464f-9b0e-13a3a9e97384}</appID>
             </application>
         </compatible_applications>      
        <all_compatible_os>
            <os>ALL</os>
                    </all_compatible_os>
        <eula></eula>
    <thumbnail>https://addons.mozilla.org/en-US/firefox/images/t/9486/943948800</thumbnail>
    <rating>5</rating>
    <learnmore>https://addons.mozilla.org/addon/1843</learnmore>
             <install hash='sha256:208912fadd26eb0e09da21300cf2bce8fc1f2883431aed07d3c36a32f7c76be3' os='ALL'>https://addons.mozilla.org/downloads/file/37452/firebug-1.2.1-fx.xpi</install>          
         </addon>
    
    </addons>

</collection>
(In reply to comment #6)

> This is what I get for a collection that I just created and added an add-on to.
> Note the creator field (and incidentally addedby field) is empty.

Do you have any more details on how you created this collection with missing info?  I can't reproduce the problem.
1) Go to https://bandwagon.stage.mozilla.com/en-US/firefox/collections/
2) Log in.
3) Click "Create a Collection".
4) Enter details, click "Create Collection".
5) Perform update in extension, watching debug output in error console.

This may be a problem with just my account, "mackers" ?
Weird, not sure what would be special about your account.  I just created another collection and added an addon, and all the info is there.  Have you tried creating another account and seeing if the issue happens with that one too?

Also, just noticed this bug is assigned to me - should I be doing something in the extension code for this?
I have spun out the empty fields bug here: bug 486130
Throwing this back to dave@briks.si, since I think bug 486130 is actually my bug
Assignee: lorchard → dave
Everything here seems to be complete (except icon url - I've filed bug 487397 for that) so I will close this bug.
Status: NEW → RESOLVED
Closed: 15 years ago
Resolution: --- → FIXED
Component: Collections → Collector Extension
QA Contact: collections → collector-extension
Product: addons.mozilla.org → addons.mozilla.org Graveyard
You need to log in before you can comment on or make changes to this bug.