470255 - Searching for "community" and/or "design" doesn't produce results

Status: VERIFIED FIXED

(Websites :: communitystore.mozilla.org, defect)

Description

[Stephen Donner [:stephend] Not actively reading bugmail]

Any variation of the strings "community" and "design" won't produce search results because those were batch-uploaded and don't have unique names--they're hardcoded.

https://community-store.authstage.mozilla.com/gallery/search?query=design
https://community-store.authstage.mozilla.com/gallery/search?query=community
https://community-store.authstage.mozilla.com/gallery/search?query=community+design

Comment 1

[Ryan Doherty (:rdoherty)]

* Make naming the design required
* Write script to take the current naming scheme for designs with no name and insert the same name into the database, which will fix the search problem.

Comment 2

[Ryan Doherty (:rdoherty)]

Also need to remove all logic that displays 'Community Design #' when there is no design name. (We could leave it because it would still work once all the designs do have a name, but I don't want unused code lying around)

Comment 3

[Ryan Doherty (:rdoherty)]

If SQL or PHP needs to be run for this bug, please add it (or a link to the bug) to https://wiki.mozilla.org/CommunityStore:2.1ITUpdates

Comment 4

[Alex Buchanan [:abuchanan]]

Attachment: patch v1

Hey,

Here's a patch for the code changes.

I'm waiting on getting an updated DB dump to write the script that changes existing empty design names.

Comment 5

[Ryan Doherty (:rdoherty)]

Comment on attachment 381324 [details] [diff] [review]
patch v1

Looks good, just missed the page title when viewing a design. (controllers/gallery.class.php line 187)

Add that and it's good to go!

Comment 6

[Ryan Doherty (:rdoherty)]

Reassigning back to Alex as he has a patch for this.

Comment 7

[Alex Buchanan [:abuchanan]]

r29763 checks in patch v1 + comment #5

Comment 8

[Alex Buchanan [:abuchanan]]

Here's the SQL to change the missing design names:

UPDATE uploads SET designname=CONCAT('Community design #', id) WHERE designname = '';


If it looks good to you, I'll add it to the wiki and close this bug.  Thanks.


The transcript,

mysql> select count(*) from uploads where designname = '';
+----------+
| count(*) |
+----------+
|      196 | 
+----------+
1 row in set (0.01 sec)

mysql> update uploads set designname=concat('Community design #', id) where designname = '';
Query OK, 196 rows affected (0.01 sec)
Rows matched: 196  Changed: 196  Warnings: 0

mysql> select count(*) from uploads where designname = '';
+----------+
| count(*) |
+----------+
|        0 | 
+----------+
1 row in set (0.00 sec)

mysql> select id, designname from uploads where designname like 'Community design%%' limit 5;
+-----+-----------------------+
| id  | designname            |
+-----+-----------------------+
| 142 | Community design #142 | 
| 143 | Community design #143 | 
| 128 | Community design #128 | 
| 129 | Community design #129 | 
|  61 | Community design #61  | 
+-----+-----------------------+
5 rows in set (0.00 sec)

Comment 9

[Ryan Doherty (:rdoherty)]

SQL looks good, just tested it.

Comment 10

[Alex Buchanan [:abuchanan]]

added the SQL to the wiki, 

https://wiki.mozilla.org/CommunityStore:2.1ITUpdates

Comment 11

[Stephen Donner [:stephend] Not actively reading bugmail]

SQL's been run on staging, right?

https://community-store.authstage.mozilla.com/gallery/search?query=community+design yields https://community-store.authstage.mozilla.com/gallery/view/421, so if so, this can be verified.

Comment 12

[Alex Buchanan [:abuchanan]]

they haven't.  justdave is running them now.

Comment 13

[Alex Buchanan [:abuchanan]]

15:35 <@justdave> Query OK, 196 rows affected (0.01 sec)
15:35 <@justdave> Rows matched: 196  Changed: 196  Warnings: 0

Comment 14

[Stephen Donner [:stephend] Not actively reading bugmail]

Verified FIXED; weird that one design was already showing up in comment 11, before the SQL was run.

All the URLs in comment 0 are now showing results.